Skip to content

Abort if no change - #49

Merged
woile merged 4 commits into
commitizen-tools:masterfrom
Lee-W:abort-if-no-change
Nov 9, 2019
Merged

Abort if no change#49
woile merged 4 commits into
commitizen-tools:masterfrom
Lee-W:abort-if-no-change

Conversation

@Lee-W

@Lee-WLee-W commented Nov 9, 2019

Copy link
Copy Markdown
Member

#45

@codecov-io

codecov-io commented Nov 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #49 into master will decrease coverage by 4.94%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #49 +/- ##
=========================================
- Coverage 93.05% 88.1% -4.95% 
=========================================
Files 24 24 Lines 547 555 +8 =========================================
- Hits 509 489 -20 - Misses 38 66 +28
Impacted FilesCoverage Δ
commitizen/git.py100% <100%> (ø)⬆️
commitizen/commands/commit.py40.42% <100%> (-52.6%)⬇️
commitizen/out.py86.66% <0%> (-13.34%)⬇️
commitizen/cz/base.py95.83% <0%> (-4.17%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6ffb0...373ec25. Read the comment docs.

@woile

woile commented Nov 9, 2019

Copy link
Copy Markdown
Member

Fine by me, if eventually someone needs --alow-empty we can consider it.

@woile
woile merged commit 0637a6b into commitizen-tools:masterNov 9, 2019
@Lee-W
Lee-W deleted the abort-if-no-change branch December 18, 2019 08:42
@alecgerona

Copy link
Copy Markdown
Contributor

@woile I think the time has come. I think we need to respect the --allow-empty flag.

@woile

Copy link
Copy Markdown
Member

Hahahah 😱
Please create a ticket describing the problem and proposed solution (sorry for the burocracy but otherwise we will forget 😅)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Lee-W@codecov-io@woile@alecgerona