Uh oh!
There was an error while loading. Please reload this page.
test(warnings): switch from the unmaintained pytest-freezegun to pytest-freezer removing warnings - #639
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## v3 #639 +/- ##
=====================================
Coverage ? 98.42% =====================================
Files ? 39 Lines ? 1655 Branches ? 0 =====================================
Hits ? 1629 Misses ? 26 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Lee-W
left a comment
There was a problem hiding this comment.
Thanks @noirbizarre !
@woile I'm planning on merging it this week. Let me know if you want to take a deeper look. Thanks!
Lee-W
commented
Dec 19, 2022
@noirbizarre I'm thinking maybe we could send this PR directly to main instead of v3. We could rebase it back to v3 later. What do you think? |
noirbizarre
commented
Dec 19, 2022
Except for the lockfile part, it can be sent to |
Lee-W
commented
Dec 19, 2022
I think we can do the relock for main and relock again after rebasing to v3. What do you think? |
noirbizarre
commented
Dec 19, 2022
I say that because we don't have a lock yet on
|
noirbizarre
commented
Dec 20, 2022
Backported in #643 but I realised that given test fixes are not on |
Lee-W
commented
Dec 21, 2022
I just merge #643 back to main. Once main is updated, you can update your local main and rebase it back to your feature branch and than force push to this branch. Thanks for the prompt PR! |
noirbizarre
commented
Dec 21, 2022
Thanks ! |
Lee-W
commented
Dec 21, 2022
indeed. I forget that 😱 let me do so now! |
7bd4fc2 to
66405eeCompareThanks, updated. But I think your working copy was not up to date and #638 is missing from the rebased |
Lee-W
commented
Dec 21, 2022
yep.... do you still have the branch on your local? |
No but I just restored it on github in the PR #638 |
Lee-W
commented
Dec 21, 2022
ah yes, we could do that. I just push that back to v3 |
…ytest-freezer` removing warnings
66405ee to
15162a3CompareAnd this is properly rebased on |
Description
Switch from
pytest-freezegunwhich is not maintained anymore and stuck on a legacyfreezegunversion raising lots of warnings topytest-freezerits maintained fork by the officialpytest-devgithub organization which is maintained and up to date, raises no warnings and provide typing.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
No behavior change expected.
Test should still pass but the 2662 warnings raised should have disappeared.
Steps to Test This Pull Request
Run the test suite
Additional context
Dependency change so the dependencies have been re-locked