Uh oh!
There was an error while loading. Please reload this page.
fix(bump): fixed environment variables in bump hooks - #675
Merged
Conversation
skoefforce-pushed
the
fix-hooks-env-regression
branch
3 times, most recently
from
February 23, 2023 17:26
d7c5337 to
dab8a7fCompareDuring development of commitizen-tools#644, merging the hook environment variables with existing OS variables broke.
skoefforce-pushed
the
fix-hooks-env-regression
branch
from
February 23, 2023 17:29
dab8a7f to
6659abaCompareCodecov ReportBase: 97.92% // Head: 98.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@## master #675 +/- ##
==========================================
+ Coverage 97.92% 98.02% +0.09%
==========================================
Files 35 40 +5 Lines 1252 1720 +468 ==========================================
+ Hits 1226 1686 +460 - Misses 26 34 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
skoef
commented
Feb 24, 2023
ContributorAuthor
@Lee-W perhaps you could take a look at it? |
Lee-W
self-requested a review
February 25, 2023 07:47
Lee-W
approved these changes
Feb 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development of #644, merging the hook environment variables with existing OS variables broke. This commit fixes that. I think it got missing during an additional rebase of that MR, but it is fixed again.