Uh oh!
There was an error while loading. Please reload this page.
feat(changelog): add merge-prerelease flag - #703
Conversation
ebf3f73 to
d5f6722CompareUh oh!
There was an error while loading. Please reload this page.
7ef678c to
23fa1b8Compare23fa1b8 to
45113d0CompareCodecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## v3 #703 +/- ##
==========================================
+ Coverage 97.98% 98.11% +0.12%
==========================================
Files 41 41 Lines 1835 1855 +20 ==========================================
+ Hits 1798 1820 +22 + Misses 37 35 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cfbbfb5 to
ab957a4CompareIt seems the pre-commit hook |
ab957a4 to
a42531bCompareFound out another reason why test would randomly fail. It's caused by concurrent tests all accessing the same temporary file for the backup of the commit message. Changing the test script to run test independently seems to solve the issue. |
16aacf5 to
0e0a012CompareMoritzBoehme
commented
Apr 16, 2023
@woile could you perhaps have a look at the pr? Do you maybe have some idea on how to keep |
| gitcommits, tags, parser, changelog_pattern, merge_prerelease=True | ||
| ) | ||
| assert tuple(tree) == COMMITS_TREE_MERGED_PRERELEASES |
There was a problem hiding this comment.
Should COMMITS_TREE_MERGED_PRERELEASES be renamed to COMMITS_TREE_AFTER_MERGED_PRERELEASES?
How is this test different than just test_generate_tree_from_commits?
There was a problem hiding this comment.
Yeah, that name is better. It's different in the sense, that COMMITS_TREE_AFTER_MERGED_PRERELEASES does not contain pre-releases (there were 2) and the changes of them are now part of the next non-prerelease.
woile
commented
Apr 16, 2023
How does this feature affect existing changelogs? |
woile
commented
Apr 16, 2023
Can you point this PR to |
MoritzBoehme
commented
Apr 16, 2023
Existing changelogs will be changed when run with this flag. This is unless you also add the
Will do! |
bde4bdc to
44ace73Compare
Running tests concurrently can cause temporary files, such as the file used to backup the commit message, to be deleted by one test but accessed by another test later on.
44ace73 to
e34de55Compare… issue with freeze_time Signed-off-by: apkawa <action@github.com> commitizen-tools#703
Description
Added a
--merge-prereleaseflag and config option as described in #687.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context
The dependency
codecovseems to be no longer available.I can try to fix it in this pull request, but could also create a new one, depending on what is preferred.I have now to my own frustration fixed the
codecovaction in the second commit. This also closes#685