Skip to content

feat(init): add pnpm support - #915

Merged
jimthedev merged 1 commit into
commitizen:masterfrom
chenaski:master
Jan 19, 2023
Merged

feat(init): add pnpm support#915
jimthedev merged 1 commit into
commitizen:masterfrom
chenaski:master

Conversation

@chenaski

@chenaskichenaski commented Mar 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Added --pnpm option. For pnpm available --save, --save-dev and --save-exact options.

Resolves: #893, resolves#858, resolves#884.

@chenaski
feat(init): add pnpm support
4c283c5
pnpm reuses options available for npm, except `force`
re: #893, re #858
@huzedong2015

huzedong2015 commented Apr 11, 2022

Copy link
Copy Markdown

How much longer will it take?

@chenaski

chenaski commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Are there any extra steps I should take?

@hellorayza

hellorayza commented May 12, 2022

Copy link
Copy Markdown

Can anyone help?

@lisen6

lisen6 commented Jun 9, 2022

Copy link
Copy Markdown

Why doesn't mine work

@pulanski

pulanski commented Jun 26, 2022

Copy link
Copy Markdown

would love to see these changes added

1 similar comment
@jiamianmao

jiamianmao commented Jul 12, 2022

Copy link
Copy Markdown

would love to see these changes added

@mattyaodoit

mattyaodoit commented Aug 12, 2022

Copy link
Copy Markdown

Keen to get this merged and support pnpm

@enrique-ramirez

enrique-ramirez commented Sep 5, 2022

Copy link
Copy Markdown

Any news on this?

@chenaski

chenaski commented Sep 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Does anyone know how everything works in this repo?

@HubooDeclan

HubooDeclan commented Nov 16, 2022

Copy link
Copy Markdown

Can we get this merged?

@AmmarArnt

AmmarArnt commented Nov 17, 2022

Copy link
Copy Markdown

Would love this PR merged too. Is this repo maintained?

@Ruobei

Ruobei commented Nov 29, 2022

Copy link
Copy Markdown

would love to see these changes added

@wangrongding

wangrongding commented Dec 4, 2022

Copy link
Copy Markdown

Looking forward to this pr being merged. 👀

@jimthedev
jimthedev merged commit c1f4142 into commitizen:masterJan 19, 2023
@github-actions

github-actionsBot commented Jan 19, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimthedev

jimthedev commented Jan 19, 2023

Copy link
Copy Markdown
Member

It released but the tests are failing. So

  1. Build should not allow this.
  2. We may need to roll back or at least mark this as breaking and fix the tests.

@chenaski

chenaski commented Jan 21, 2023

Copy link
Copy Markdown
ContributorAuthor

I don't think there are any breaking changes, it seems I just forgot to update azure pipeline.
We need to add a pnpm installation before running the tests.

@chenaskichenaski mentioned this pull request Jan 21, 2023
Merged
@Jalever

Jalever commented Aug 16, 2023

Copy link
Copy Markdown

Great!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimthedevjimthedevjimthedev approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: add pnpm flag to the commitizen init flag Initialization error commitizen init doesn't work with pnpm

14 participants

@chenaski@huzedong2015@hellorayza@lisen6@pulanski@jiamianmao@mattyaodoit@enrique-ramirez@HubooDeclan@AmmarArnt@Ruobei@wangrongding@jimthedev@Jalever