Skip to content

Attempt at Supporting Overriding Core Delimiter Processors - #432

Open
rdestefa wants to merge 1 commit into
commonmark:mainfrom
rdestefa:issue-386-override-default-delimiter-processor
Open

Attempt at Supporting Overriding Core Delimiter Processors#432
rdestefa wants to merge 1 commit into
commonmark:mainfrom
rdestefa:issue-386-override-default-delimiter-processor

Conversation

@rdestefa

@rdestefardestefa commented May 2, 2026

Copy link
Copy Markdown
Contributor

Quick attempt at supporting #386. Not sure if I've covered all edge cases or if there's a simpler way to do this, so might come back to this later.

@rdestefa
rdestefaforce-pushed the issue-386-override-default-delimiter-processor branch from 97f4b43 to 8a1d8f7CompareMay 2, 2026 09:05
@robinst

Copy link
Copy Markdown
Collaborator

Instead of a separate configuration, can you explore how it would look if the normal customDelimiterProcessor would just be able to override built-in ones? I think we'd still want to error if a user accidentally specifies two processors with the same configuration, but not if they override a built-in one (i.e. add the custom ones first, then add the built-in ones if they don't have conflicts).

@robinstrobinst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rdestefa@robinst