Uh oh!
There was an error while loading. Please reload this page.
Eliminate complex typed static variables - #37
Open
espakm wants to merge 1 commit into
Open
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex typed static variables (e.g. maps) in dll-s are to avoid.
On Windows they are initialised late when the dll
is being loaded dynamically. The current use of static QHash data members
results in crash on Windows when a PythonQt.dll static function is called from a static initialization code from a dependent library, and PythonQt.dll has not been loaded before, already.
See details here:
http://stackoverflow.com/questions/5114683/loading-dll-not-initializing-static-c-classes