Skip to content

Add ability to open files - #45

Merged
conaticus merged 4 commits into
devfrom
file_opening
Jul 1, 2023
Merged

Add ability to open files#45
conaticus merged 4 commits into
devfrom
file_opening

Conversation

@conaticus

Copy link
Copy Markdown
Owner

No description provided.

@conaticusconaticus added the enhancement New feature or request label Jun 30, 2023
Comment threadsrc-tauri/src/filesystem/mod.rs Outdated
@conaticus

conaticus commented Jun 30, 2023

Copy link
Copy Markdown
OwnerAuthor

Found a mistake, also going to change the tauri command to return a string if an error occurs.

LeoCatsune
LeoCatsune previously requested changes Jun 30, 2023

@LeoCatsuneLeoCatsune left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks decent, but some changes needed.

Comment threadsrc-tauri/src/filesystem/mod.rs Outdated
Comment threadsrc-tauri/src/filesystem/mod.rs Outdated
@conaticus
conaticus merged commit 80c1145 into devJul 1, 2023
@conaticusconaticus mentioned this pull request Jul 1, 2023
@conaticus
conaticus deleted the file_opening branch July 1, 2023 11:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@conaticus@LeoCatsune