Skip to content

REF remove extra base_version key to allow bot to update python - #315

Merged
scopatz merged 4 commits into
conda-forge:masterfrom
beckermr:beckermr-patch-1
Feb 28, 2020
Merged

REF remove extra base_version key to allow bot to update python#315
scopatz merged 4 commits into
conda-forge:masterfrom
beckermr:beckermr-patch-1

Conversation

@beckermr

@beckermrbeckermr commented Feb 26, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This change will allow the auto-tick bot to push version updates I think.

@conda-forge-linter

conda-forge-linter commented Feb 26, 2020

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr

beckermr commented Feb 26, 2020

Copy link
Copy Markdown
MemberAuthor

@conda-forge-admin rerender

@beckermr

beckermr commented Feb 26, 2020

Copy link
Copy Markdown
MemberAuthor

We are missing this one on drone


conda.exceptions.ResolvePackageNotFound:
--
471 | - libx11-devel-cos7-aarch64

@isuruf

isuruf commented Feb 26, 2020

Copy link
Copy Markdown
Member

@beckermr, I restarted https://dev.azure.com/conda-forge/feedstock-builds/_build?definitionId=9061&_a=summary

@beckermr

beckermr commented Feb 26, 2020

Copy link
Copy Markdown
MemberAuthor

Looks like that job failed too with another error?

conda.exceptions.ResolvePackageNotFound: - libx11-cos7-aarch64==1.6.7

@jjhelmusjjhelmus mentioned this pull request Feb 27, 2020
Merged
5 tasks
@beckermr

beckermr commented Feb 27, 2020

Copy link
Copy Markdown
MemberAuthor

@conda-forge-admin, please rerender

@conda-forge-linter

conda-forge-linter commented Feb 27, 2020

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@isuruf

isuruf commented Feb 28, 2020

Copy link
Copy Markdown
Member

Drone build succeeded, but it's shown as pending still. Ready for review

@mariusvniekerk

mariusvniekerk commented Feb 28, 2020

Copy link
Copy Markdown
Member

Looks fine to me

scopatz
scopatz reviewed Feb 28, 2020
View reviewed changes
Comment threadrecipe/meta.yaml
# Would like to be able to append to the calculated build string here, ping @msarahan, is this possible?
string: h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}{{ linkage_nature }}{{ debug }}_cpython
run_exports:
- python_abi 3.8.* cp38

@scopatzscopatzFeb 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to remove run_exports @conda-forge/python?

@isurufisurufFeb 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added after there's a new conda-build release. There's also #310 which uses the correct syntax for the new conda-build release.

@beckermrbeckermrFeb 28, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf

@scopatzscopatzFeb 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then!

@scopatz
scopatz merged commit 4a6f762 into conda-forge:masterFeb 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scopatzscopatzscopatz left review comments
@isurufisurufisuruf left review comments
@jakirkhamjakirkhamAwaiting requested review from jakirkham
@jjhelmusjjhelmusAwaiting requested review from jjhelmus
@mingwandroidmingwandroidAwaiting requested review from mingwandroid
@msarahanmsarahanAwaiting requested review from msarahan
@ocefpafocefpafAwaiting requested review from ocefpaf
@pelsonpelsonAwaiting requested review from pelson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@beckermr@conda-forge-linter@isuruf@mariusvniekerk@scopatz@conda-forge-admin