Skip to content

Drop Circle CI config from recipe - #599

Draft
conda-forge-linter wants to merge 3 commits into
conda-forge:mainfrom
conda-forge-linter:conda_forge_admin_598
Draft

Drop Circle CI config from recipe#599
conda-forge-linter wants to merge 3 commits into
conda-forge:mainfrom
conda-forge-linter:conda_forge_admin_598

Conversation

@conda-forge-linter

@conda-forge-linterconda-forge-linter commented Nov 15, 2022•
edited by jakirkham
Loading

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #598.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes#598
Fixes#600

@conda-forge-linterconda-forge-linter mentioned this pull request Nov 15, 2022
Closed
@conda-forge-linter

conda-forge-linter commented Nov 15, 2022

Copy link
Copy Markdown
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham

jakirkham commented Nov 15, 2022

Copy link
Copy Markdown
Member

@conda-forge-admin, please re-render

@jakirkhamjakirkham changed the title MNT: rerenderDrop Circle CI config from recipeNov 15, 2022
mbargull
mbargull requested changes Nov 15, 2022
View reviewed changes

@mbargullmbargull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rerendering updated the compilers on Windows, we should probably bump the build number.

@jakirkham

jakirkham commented Nov 15, 2022

Copy link
Copy Markdown
Member

Actually would prefer to put this into a PR that is already going in. Seems silly just to include this change alone (though suppose we could)

@mbargull

mbargull commented Nov 15, 2022

Copy link
Copy Markdown
Member

Yes, makes sense.
(Foremost, I added the review to avoid an early merge -- I'm a fan of the "draft PR" feature ;).)

@mbargull
mbargull marked this pull request as draft November 15, 2022 19:42
@jakirkham

jakirkham commented Nov 15, 2022

Copy link
Copy Markdown
Member

Yeah it was a bot PR. So it didn't start as a draft, but yeah marking it as such makes sense

@nikhilweee

nikhilweee commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Happy to add this in #597

@jakirkham

jakirkham commented Nov 16, 2022

Copy link
Copy Markdown
Member

That would be great! Thank you 🙏

@nikhilweee

nikhilweee commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Done

@nikhilweeenikhilweee mentioned this pull request Nov 16, 2022
Merged
5 tasks
@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown

I think this can be closed.

@jakirkham

jakirkham commented Feb 1, 2023

Copy link
Copy Markdown
Member

Why? It appears to be unaddressed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbargullmbargullmbargull requested changes
@chrisburrchrisburrAwaiting requested review from chrisburrchrisburr is a code owner
@isurufisurufAwaiting requested review from isurufisuruf is a code owner
@jakirkhamjakirkhamAwaiting requested review from jakirkhamjakirkham is a code owner
@katietzkatietzAwaiting requested review from katietzkatietz is a code owner
@mingwandroidmingwandroidAwaiting requested review from mingwandroid
@msarahanmsarahanAwaiting requested review from msarahanmsarahan is a code owner
@ocefpafocefpafAwaiting requested review from ocefpafocefpaf is a code owner
@pelsonpelsonAwaiting requested review from pelsonpelson is a code owner
@scopatzscopatzAwaiting requested review from scopatzscopatz is a code owner
@xhochyxhochyAwaiting requested review from xhochyxhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove CircleCI config from recipe @conda-forge-admin, please re-render

6 participants

@conda-forge-linter@jakirkham@mbargull@nikhilweee@mattip@conda-forge-admin