Skip to content

[3.14] Revert 907 - #909

Merged
conda-forge-admin merged 3 commits into
conda-forge:3.14from
isuruf:rev
Aug 31, 2026
Merged

[3.14] Revert 907#909
conda-forge-admin merged 3 commits into
conda-forge:3.14from
isuruf:rev

Conversation

@isuruf

Copy link
Copy Markdown
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin

conda-forge-admin commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33362041657. Examine the logs at this URL for more detail.

@isurufisuruf changed the title Revert 907[3.14] Revert 907Aug 31, 2026
@h-vetinari

Copy link
Copy Markdown
Member

You could have simply reverted 4f37d40 & f82dda2, rather than the whole PR? The difference would be keeping 4a842a4

@h-vetinari

Copy link
Copy Markdown
Member

Actually, I think we should keep 4f37d40 too; the script tests for libpython make no sense anymore after the build order was changed. It should only have file-based tests IMO

@h-vetinari

Copy link
Copy Markdown
Member

See #911 for an alternative that I think is cleaner. I've kept your e7670be from here.

@isuruf

Copy link
Copy Markdown
MemberAuthor

I've pushed to this branch. 4a842a4 is reverted too. I don't see a reason why it should be there. If you see it again in a log, please open an issue

@isurufisuruf added the automerge Merge the PR when CI passes label Aug 31, 2026
@isuruf

Copy link
Copy Markdown
MemberAuthor

I've kept 4f37d40 as is

@h-vetinari

Copy link
Copy Markdown
Member

If you see it again in a log, please open an issue

Hm. I don't regularly go over the logs with a fine-toothed comb, so this will be easy to miss if it happens again. But 🤷

@conda-forge-admin
conda-forge-admin merged commit ec8a1a1 into conda-forge:3.14Aug 31, 2026
31 checks passed
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automergeMerge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@isuruf@conda-forge-admin@h-vetinari