Uh oh!
There was an error while loading. Please reload this page.
[APIE-1077] Tableflow GCP Support - #3493
Draft
Yifei Yuan (yyuan097) wants to merge 5 commits into
Draft
Conversation
The public ccloud-sdk-go-v2/tableflow SDK has not yet been regenerated with the GCP types (GoogleCloudStorageSpec, CatalogIntegrationBigLakeMetastoreSpec), so temporarily switch the tableflow dependency to the internal ccloud-sdk-go-v2-internal/tableflow v0.28.0. Revert to the public SDK once it is regenerated with GCP support (confluentinc/ccloud-sdk-go-v2#373). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add integration test coverage for the GoogleCloudStorage topic storage type: enable, describe (table + json), and delete for a topic-gcp fixture, plus the getTopicGcp mock and regenerated golden files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
--storage-type GoogleCloudStorageGCP support forconfluent tableflow topic enablecommandBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Added CLI support for Tableflow GCP via
--storage-type GoogleCloudStorageBlast Radius
Low to none. Additive change, does not affect existing storage types, could affect
tableflow [enable | list | describe]with type Google Cloud Storage in the worst case scenario.References
https://confluentinc.atlassian.net/browse/APIE-1077
Test & Review
Integration Tests & new golden files added:
Tested in
develenvironment.Enable tableflow for gcp:

E2E Manual Verification and Integration test:
Tableflow GCP Support - CLI testing