Don't call socket task dispose

[Tar-Elendil]

This PR removes the direct call to Task.Dispose in QuickFIXn/SocketReader.cs
fixes #1025

The task does not always reach a completed state before the 1s timeout is reached and Dispose is called.
I don't believe that we strictly need to dispose the task here as the CancellationToken is cancelled. The task should complete eventually.

[CLAassistant]

All committers have signed the CLA.

[stic]

This PR removes the direct call to Task.Dispose in QuickFIXn/SocketReader.cs fixes #1025

The task does not always reach a completed state before the 1s timeout is reached and Dispose is called. I don't believe that we strictly need to dispose the task here as the CancellationToken is cancelled. The task should complete eventually.

That's true .Dispose() isn't needed since .net 4.5, just set it back to null? However, as is the change would eliminate the 1 second delay, isn't it?

Also, in SocketInittiatorThread you have the same pattern.

[Tar-Elendil]

That's true .Dispose() isn't needed since .net 4.5, just set it back to null? However, as is the change would eliminate the 1 second delay, isn't it?

Also, in SocketInittiatorThread you have the same pattern.

Thanks I forgot about the Initiator.

Yes, there shouldn't be a performance impact and socket disconnects shouldn't be happening frequently.
I should've linked this blog.

You're right about the 1s delay. We need that to allow any existing wait op to complete.