Add Volume Health Support to CSI by xing-yang · Pull Request #415 · container-storage-interface/spec

xing-yang · 2020-02-10T20:44:19Z

This PR adds volume health support to CSI spec.

Fixes: #410

jdef

Several nits and renames suggested.

Also, if a plugin supports VOLUME_HEALTH, is there any reason why the list-volumes call can't return health for each of the volumes it reports?

xing-yang · 2020-02-11T16:56:29Z

Also, if a plugin supports VOLUME_HEALTH, is there any reason why the list-volumes call can't return health for each of the volumes it reports?

Many CSI drivers don't support ListVolumes because it is expensive to make such a call. We could add a volume_id as a filter in ListVolumes but that means drivers have to implement ListVolumes in order to get information from a specific volume. During a previous review meeting, @saad-ali has suggested it is better to have a separate GetVolume RPC.

jdef · 2020-02-11T18:34:09Z

I think my suggestion may have been misinterpreted. I wasn't suggesting the elimination of GetVolume. Instead, I was suggesting that, for those plugins that already implement list-volumes, maybe they would also be interested in reporting health information that way.

…

On Tue, Feb 11, 2020 at 11:56 AM Xing Yang ***@***.***> wrote: Also, if a plugin supports VOLUME_HEALTH, is there any reason why the list-volumes call can't return health for each of the volumes it reports? Many CSI drivers don't support ListVolumes because it is expensive to make such a call. We could add a volume_id as a filter in ListVolumes but that means drivers have to implement ListVolumes in order to get information from a specific volume. During a previous review meeting, @saad-ali <https://github.com/saad-ali> has suggested it is better to have a separate GetVolume RPC. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#415?email_source=notifications&email_token=AAR5KLGYEZYTMCUFWGSAU4TRCLKD5A5CNFSM4KSVIF22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELNF4AQ#issuecomment-584736258>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLFTVDTGRS4VA3GQ6XLRCLKD5ANCNFSM4KSVIF2Q> .

-- James DeFelice 585.241.9488 (voice) 650.649.6071 (fax)

xing-yang · 2020-02-12T20:39:19Z

I think my suggestion may have been misinterpreted. I wasn't suggesting the
elimination of GetVolume. Instead, I was suggesting that, for those plugins
that already implement list-volumes, maybe they would also be interested in
reporting health information that way.

Sure, I can add volume health in ListVolumes.

xing-yang

Addressed review comments. Thanks.

msau42 · 2020-02-12T20:59:57Z

cc @bswartz

xing-yang · 2020-02-13T03:17:59Z

Addressed Ben's comments. Thanks.

xing-yang · 2020-02-13T03:44:39Z

@jdef I have marked the new method, message, and field experimental based on your PR (#365). Can you please take a look? 5c862b2

bswartz

I have reviewed these changes and I'm satisfied.

xing-yang · 2020-02-18T20:16:22Z

@julian-hj, @msau42 addressed your your comments. PTAL. Thanks.

julian-hj

👍

jdef · 2020-02-24T01:32:15Z

@jdef I have marked the new method, message, and field experimental based on your PR (#365). Can you please take a look? 5c862b2

It looks like some, not all of the Alpha API support is being added in this PR. While the work committed here isn't misaligned with #365, it is incomplete w/ respect to what was proposed.

Suggestion: cherry-pick the following commits from #365 such that Alpha API support is added comprehensively instead of piecemeal, which will make it more clear for others looking to adopt.

Or, maybe it would be cleaner to fast-track the above, suggested commits in a separate PR, merge that, and then rebase this one on top? I'm flexible here, just looking for a clear commit stream.

jdef

I should have marked my last review as "request changes" - sorry for the confusion.

xing-yang · 2020-02-24T02:20:46Z

@jdef I submitted the alpha api support PR separately here: #417. Will rebase this PR once that one is merged.

xing-yang · 2020-02-24T03:04:14Z

@jdef Addressed most of your comments. I'll rebase this on the alpha api PR and address your remaining comment regarding the alpha feature.

xing-yang · 2020-02-24T03:21:14Z

Rebased.

xing-yang · 2020-02-24T03:28:23Z

Hi @jdef, I addressed all your comments. Please take a look again. Thanks.

xing-yang · 2020-03-14T02:26:08Z

Hi @saad-ali, I updated the PR based on what we concluded in the review meeting. Please take a look. Thanks.

jieyu

some nits, but overall, lgtm

xing-yang · 2020-04-10T02:53:49Z

All comments are addressed. Please take a look again.

xing-yang · 2020-04-11T15:05:57Z

@saad-ali Addressed your comments. PTAL.

saad-ali

Thanks @xing-yang

/lgtm
/approve

saad-ali · 2020-04-12T22:38:22Z

@jdef @jieyu @julian-hj all good?

@xing-yang Please squash commits and I can help merge.

xing-yang · 2020-04-13T01:31:04Z

Thanks @saad-ali. Squashed commits into 1.

xing-yang · 2020-04-13T03:16:57Z

Thanks @jdef. Addressed your comments.

jdef · 2020-04-13T11:08:05Z

LGTM

saad-ali · 2020-04-13T17:47:58Z

@xing-yang please squash one more time and I'll merge

jieyu

lgtm

xing-yang · 2020-04-13T19:24:14Z

Squashed commits. Thanks @saad-ali and @jieyu.

saad-ali · 2020-04-15T02:24:10Z

Thanks. Merging.

julian-hj reviewed Feb 10, 2020
View reviewed changes

Comment threadcsi.proto Outdated

xing-yang force-pushed the volumehealth branch from 276c4ec to 277cefeCompare February 11, 2020 03:54

jdef reviewed Feb 11, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated

xing-yang commented Feb 12, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated

bswartz requested changes Feb 12, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

xing-yang changed the title ~~WIP: Add Volume Health Support to CSI~~Add Volume Health Support to CSIFeb 13, 2020

xing-yang force-pushed the volumehealth branch 2 times, most recently from dcd82db to da542ddCompare February 13, 2020 14:37

bswartz approved these changes Feb 13, 2020
View reviewed changes

julian-hj reviewed Feb 14, 2020
View reviewed changes

Comment threadcsi.proto Outdated

xing-yang force-pushed the volumehealth branch from a72e2a4 to 5177b70Compare February 15, 2020 15:20

msau42 reviewed Feb 19, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

julian-hj approved these changes Feb 19, 2020
View reviewed changes

xing-yang mentioned this pull request Feb 20, 2020
PV Health Monitor kubernetes/enhancements#1432
Open
8 tasks

jdef reviewed Feb 24, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md
Comment threadspec.md Outdated
Comment threadspec.md Outdated

jdef reviewed Feb 24, 2020
View reviewed changes

Comment threadspec.md Outdated

jdef requested changes Feb 24, 2020
View reviewed changes

xing-yang force-pushed the volumehealth branch from dca1151 to 0e5a1ffCompare February 24, 2020 03:20

jieyu reviewed Apr 1, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

jieyu reviewed Apr 1, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

jieyu reviewed Apr 1, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

xing-yang force-pushed the volumehealth branch from 22dcabc to 86ce098Compare April 1, 2020 19:21

jieyu approved these changes Apr 1, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

saad-ali requested changes Apr 2, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated

xing-yang force-pushed the volumehealth branch from 76881f6 to 1a51367Compare April 2, 2020 14:51

jieyu reviewed Apr 2, 2020
View reviewed changes

Comment threadcsi.proto Outdated
Comment threadcsi.proto Outdated

saad-ali reviewed Apr 8, 2020
View reviewed changes

saad-ali reviewed Apr 10, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated

saad-ali approved these changes Apr 12, 2020
View reviewed changes

xing-yang force-pushed the volumehealth branch from a15a86a to 843742fCompare April 13, 2020 01:29

jdef reviewed Apr 13, 2020
View reviewed changes

Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated
Comment threadspec.md Outdated

jdef approved these changes Apr 13, 2020
View reviewed changes

jieyu approved these changes Apr 13, 2020
View reviewed changes

Add Volume Health Support to CSI
ecaa329

xing-yang force-pushed the volumehealth branch from f3133c6 to ecaa329Compare April 13, 2020 19:23

saad-ali merged commit e129a75 into container-storage-interface:masterApr 15, 2020

xing-yang mentioned this pull request Apr 24, 2020
Health check by CSI driver kubernetes/kubernetes#74359
Closed

xing-yang mentioned this pull request May 31, 2020
Mock ControllerGetVolume/NodeGetVolumeStats/ListVolumes RPCs to test controller/agent here kubernetes-csi/external-health-monitor#9
Closed

Uh oh!

Conversation

xing-yang commented Feb 10, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jdef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xing-yang commented Feb 11, 2020

Uh oh!

jdef commented Feb 11, 2020 via email

Uh oh!

xing-yang commented Feb 12, 2020

Uh oh!

xing-yang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msau42 commented Feb 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xing-yang commented Feb 13, 2020

Uh oh!

xing-yang commented Feb 13, 2020

Uh oh!

bswartz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xing-yang commented Feb 18, 2020

Uh oh!

Uh oh!

Uh oh!

julian-hj left a comment

Choose a reason for hiding this comment

Uh oh!

jdef commented Feb 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdef left a comment

Choose a reason for hiding this comment

Uh oh!

xing-yang commented Feb 24, 2020

Uh oh!

xing-yang commented Feb 24, 2020

Uh oh!

xing-yang commented Feb 24, 2020

Uh oh!

xing-yang commented Feb 24, 2020

Uh oh!

xing-yang commented Mar 14, 2020

Uh oh!

Uh oh!

Uh oh!

xing-yang commented Feb 10, 2020•
edited
Loading