Uh oh!
There was an error while loading. Please reload this page.
throttle.* metrics must be kept for non-CFQ schedulers - #147
Merged
Conversation
Since c4b9ac5, Stat() ignores /sys/fs/cgroup/blkio/$cgroup/blkio.throttle.io_serviced and /sys/fs/cgroup/blkio/$cgroup/blkio.throttle.io_service_bytes when /sys/fs/cgroup/blkio/$cgroup/blkio.io_serviced_recursive is there. However the existance of this file only indicates that the kernel is compiled with the CFQ scheduler. There is a chance that a cgroup uses devices with a different scheduler such as "none". Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
commented
Mar 5, 2020
MemberAuthor
Looks like the test failure is not related to my change. |
Zyqsempai
commented
Mar 5, 2020
Contributor
@kzys Try to restart CI by pushing empty commit, it happens sometimes. |
This change essentially skips the test in Travis though. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
commented
Mar 6, 2020
MemberAuthor
@Zyqsempai Thanks! The test is passing, while I have to skip the test in Travis though. |
AkihiroSuda
commented
Mar 6, 2020
Member
@fuweid PTAL |
crosbymichael
commented
Mar 6, 2020
Member
LGTM |
mxpv added a commit
to mxpv/containerd
that referenced
this pull request
Apr 14, 2020
Backport cgroups fix: containerd/cgroups#147 Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since c4b9ac5, Stat() ignores
/sys/fs/cgroup/blkio/$cgroup/blkio.throttle.io_serviced and
/sys/fs/cgroup/blkio/$cgroup/blkio.throttle.io_service_bytes when
/sys/fs/cgroup/blkio/$cgroup/blkio.io_serviced_recursive is there.
However the existance of this file only indicates that the kernel is
compiled with the CFQ scheduler. There is a chance that a cgroup uses
devices with a different scheduler such as "none".
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com