Skip to content

fix: don't print to stdout when initializing console fails on Windows - #66

Merged
estesp merged 1 commit into
containerd:mainfrom
muesli:windows-printf
Mar 13, 2023
Merged

fix: don't print to stdout when initializing console fails on Windows#66
estesp merged 1 commit into
containerd:mainfrom
muesli:windows-printf

Conversation

@muesli

@mueslimuesli commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

When stdin/err/out are redirected, console mode can't be changed. That's often expected & acceptable however, so we shouldn't print errors to stdout.

@mueslimuesli mentioned this pull request Oct 21, 2022
Closed
@TheReptarTheReptar mentioned this pull request Nov 29, 2022
Merged
@0xdhrv0xdhrv mentioned this pull request Feb 1, 2023
Open
@WithHolmWithHolm mentioned this pull request Feb 12, 2023
Open
@mueslimuesli mentioned this pull request Mar 7, 2023
Closed
kzys
kzys approved these changes Mar 7, 2023
View reviewed changes
@kzys

kzys commented Mar 7, 2023

Copy link
Copy Markdown
Member

@kevpar@dcantah PTAL

dcantah
dcantah reviewed Mar 7, 2023
View reviewed changes
Comment threadconsole_windows.go Outdated
dcantah
dcantah reviewed Mar 9, 2023
View reviewed changes
Comment threadconsole_windows.go
dcantah
dcantah approved these changes Mar 9, 2023
View reviewed changes

@dcantahdcantah left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to get rid of the branches/commented out errors with a little note that we can explore handling redirected io via the conout/in shenanigans, but LGTM!

@muesli
fix: don't print to stdout when initializing console fails on Windows
7b7885a
When stdin/err/out are redirected, console mode can't be changed.
That's often expected & acceptable however, so we shouldn't print
errors to stdout.
Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com>
@muesli

muesli commented Mar 10, 2023

Copy link
Copy Markdown
ContributorAuthor

I'd prefer to get rid of the branches/commented out errors with a little note that we can explore handling redirected io via the conout/in shenanigans, but LGTM!

Done. PTAL!

dcantah
dcantah approved these changes Mar 13, 2023
View reviewed changes

@dcantahdcantah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again. @kzys PTAL/merge if you're alright with this, thanks @muesli

@estesp
estesp merged commit 1ae8d48 into containerd:mainMar 13, 2023
@muesli
muesli deleted the windows-printf branch March 14, 2023 06:34
This was referenced Feb 2, 2024
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzyskzyskzys approved these changes
@estespestespestesp approved these changes
@dcantahdcantahdcantah approved these changes
+1 more reviewer
@caarlos0caarlos0caarlos0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@muesli@kzys@caarlos0@estesp@dcantah@dmcgowan