Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 3, 2018. It is now read-only.
cni: Fix bug while updating endpoints after scanning net namespace - #488
Merged
Conversation
After scanning the network namespace, we need to update the scanned endpoints with the DNS information, and use the scanned endpoints thereafter discarding the endpoints structures we had created prior to calling into the CNI plugin. There was a bug in the update, which was causing the entire endpoint structure being assigned back to the scanned endpoints causing us to lose information from the scan including if a virtual or physical endpoint was found in the scan. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Collaborator
LGTM |
sameo
approved these changes
Nov 19, 2017
In addition to the DNS, we need to copy the netpair struct as well from the endpoint structures we created prior to the network creation to the endpoints created after scanning the network. This is needed for creating the tap and bridge interfaces for virtual endpoints. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
commented
Nov 20, 2017
CollaboratorAuthor
sboeuf
approved these changes
Nov 20, 2017
sboeuf
commented
Nov 20, 2017
Collaborator
LGTM |
amshinde
commented
Nov 20, 2017
CollaboratorAuthor
@sboeuf I have run a manual test with cni-bridge plugin as well,able to see the network setup correctly and the pod is deleted successfully. |
sboeuf
commented
Nov 20, 2017
Collaborator
@amshinde thanks for that ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After scanning the network namespace, we need to update the scanned
endpoints with the DNS information, and use the scanned endpoints
thereafter discarding the endpoints structures we had created prior
to calling into the CNI plugin.
There was a bug in the update, which was causing the entire endpoint
structure being assigned back to the scanned endpoints causing us to
lose information from the scan including if a virtual or physical
endpoint was found in the scan.
Signed-off-by: Archana Shinde archana.m.shinde@intel.com