Skip to content

Enhance SyncStack to handle ArrayList - #205

Merged
reeshika-h merged 2 commits into
developmentfrom
fix/DX-3132-sync-setJson
Jun 5, 2025
Merged

Enhance SyncStack to handle ArrayList #205
reeshika-h merged 2 commits into
developmentfrom
fix/DX-3132-sync-setJson

Conversation

@reeshika-h

Copy link
Copy Markdown
Contributor
  • Improved error logging for 'items' processing
  • Added test for real API call to syncContentType

…items' processing
Added test for real API call to syncContentType.
@aman19K
aman19K requested a review from CopilotJune 4, 2025 10:57

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the SyncStack module by allowing the processing of items provided as ArrayLists and improves error logging while adding a new integration test for syncContentType real API calls.

  • Added ArrayList support for 'items' processing in SyncStack.
  • Improved error logging messages for invalid 'items' types.
  • Introduced a real API call test for syncContentType with asynchronous handling.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
src/test/java/com/contentstack/sdk/TestSyncStack.javaAdded testRealSyncContentType method to validate actual API responses.
src/main/java/com/contentstack/sdk/SyncStack.javaHandled ArrayList in items processing with additional logging.

Comment threadsrc/main/java/com/contentstack/sdk/SyncStack.java Outdated
Comment threadsrc/main/java/com/contentstack/sdk/SyncStack.java Outdated
nadeem-cs
nadeem-cs previously approved these changes Jun 4, 2025
…ancing flexibility in handling various collection types.

@AniketDev7AniketDev7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reeshika-h
reeshika-h marked this pull request as ready for review June 5, 2025 07:11
@reeshika-h
reeshika-h requested a review from a team as a code ownerJune 5, 2025 07:11
@reeshika-h
reeshika-h merged commit 043e2c7 into developmentJun 5, 2025
@reeshika-h
reeshika-h deleted the fix/DX-3132-sync-setJson branch November 26, 2025 06:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@reeshika-h@AniketDev7@nadeem-cs