Skip to content

feat: Complete Assets module STJ migration (v1.0.0-beta.4) - #177

Merged
sunil-lakshman merged 6 commits into
enhc/betafrom
enhc/DX-7304
May 22, 2026
Merged

feat: Complete Assets module STJ migration (v1.0.0-beta.4)#177
sunil-lakshman merged 6 commits into
enhc/betafrom
enhc/DX-7304

Conversation

@OMpawar-21

Copy link
Copy Markdown
Contributor

Summary

This PR migrates the Assets module from Newtonsoft.Json to System.Text.Json, improving performance and reducing dependencies.

Changes Made

Models Updated

  • Updated Asset, Folder, and Version models to use System.Text.Json
  • Maintained backward compatibility for existing API consumers

Services Migrated

  • Migrated asset upload, folder management, and versioning services
  • Replaced legacy JSON serialization with modern STJ APIs
  • Updated service constructors to use JsonSerializerOptions

Performance Improvements

  • Reduced memory allocation during JSON operations
  • Improved serialization performance for asset operations
  • Streamlined JSON writing with Utf8JsonWriter

Technical Details

  • All asset-related services now use System.Text.Json
  • Service constructors updated to accept JsonSerializerOptions
  • JSON writing operations migrated to Utf8JsonWriter
  • Zero breaking changes to public API

Testing

  • All builds pass successfully
  • Asset operations function correctly
  • No regressions in existing functionality

Breaking Changes

None. This is an internal refactoring that maintains full API compatibility.

Benefits

  • Improved JSON serialization performance
  • Reduced package dependencies
  • Better alignment with .NET ecosystem standards
  • Enhanced memory efficiency for asset operations

- Migrate Asset.cs, AssetModel.cs, Folder.cs, Version.cs to System.Text.Json
- Update service constructors to use JsonSerializerOptions instead of JsonSerializer
- Replace JsonTextWriter with Utf8JsonWriter in asset services
- Re-enable Stack.Asset() method and asset-related services in csproj
@OMpawar-21
OMpawar-21 requested a review from a team as a code ownerMay 20, 2026 06:58
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check TypeCount (with fixes)Without fixesThresholdResult
🔴 Critical Severity0010✅ Passed
🟠 High Severity0025✅ Passed
🟡 Medium Severity00500✅ Passed
🔵 Low Severity001000✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

SeverityBreaches (with fixes)Breaches (no fixes)SLA Threshold (with/no fixes)Status
🔴 Critical0015 / 30 days✅ Passed
🟠 High0030 / 120 days✅ Passed
🟡 Medium0090 / 365 days✅ Passed
🔵 Low00180 / 365 days✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check TypeCount (with fixes)Without fixesThresholdResult
🔴 Critical Severity0010✅ Passed
🟠 High Severity0025✅ Passed
🟡 Medium Severity00500✅ Passed
🔵 Low Severity001000✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

SeverityBreaches (with fixes)Breaches (no fixes)SLA Threshold (with/no fixes)Status
🔴 Critical0015 / 30 days✅ Passed
🟠 High0030 / 120 days✅ Passed
🟡 Medium0090 / 365 days✅ Passed
🔵 Low00180 / 365 days✅ Passed

✅ BUILD PASSED - All security checks passed

@sunil-lakshmansunil-lakshman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunil-lakshman
sunil-lakshman merged commit 7807e2b into enhc/betaMay 22, 2026
11 checks passed
@sunil-lakshman
sunil-lakshman deleted the enhc/DX-7304 branch May 22, 2026 07:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@OMpawar-21@sunil-lakshman