Skip to content

feat: migrate Environment and Global Field modules to System.Text.Json - #178

Merged
sunil-lakshman merged 8 commits into
enhc/betafrom
enhc/DX-7298
May 22, 2026
Merged

feat: migrate Environment and Global Field modules to System.Text.Json#178
sunil-lakshman merged 8 commits into
enhc/betafrom
enhc/DX-7298

Conversation

@OMpawar-21

Copy link
Copy Markdown
Contributor

Summary

Migrates Environment and Global Field modules from Newtonsoft.Json to System.Text.Json as part of the ongoing modernization effort.

Changes

  • Migrate Environment and Global Field models to use System.Text.Json attributes
  • Update service layer to use JsonSerializerOptions and modern serialization patterns
  • Re-enable previously disabled modules in project configuration
  • Ensure compatibility with existing STJ infrastructure

Technical Updates

  • Replace legacy JSON attributes with System.Text.Json equivalents
  • Update service constructors and serialization methods
  • Maintain API compatibility and existing interfaces
  • Follow established patterns from previous migrations

Benefits

  • Improved performance with System.Text.Json
  • Reduced dependency on legacy Newtonsoft.Json package
  • Consistent serialization approach across the SDK
  • Better integration with modern .NET ecosystem

Testing

  • All modules build successfully
  • No breaking changes to public APIs
  • Maintains backward compatibility

- Migrate Asset.cs, AssetModel.cs, Folder.cs, Version.cs to System.Text.Json
- Update service constructors to use JsonSerializerOptions instead of JsonSerializer
- Replace JsonTextWriter with Utf8JsonWriter in asset services
- Re-enable Stack.Asset() method and asset-related services in csproj
@OMpawar-21
OMpawar-21 requested a review from a team as a code ownerMay 20, 2026 11:28
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check TypeCount (with fixes)Without fixesThresholdResult
🔴 Critical Severity0010✅ Passed
🟠 High Severity0025✅ Passed
🟡 Medium Severity00500✅ Passed
🔵 Low Severity001000✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

SeverityBreaches (with fixes)Breaches (no fixes)SLA Threshold (with/no fixes)Status
🔴 Critical0015 / 30 days✅ Passed
🟠 High0030 / 120 days✅ Passed
🟡 Medium0090 / 365 days✅ Passed
🔵 Low00180 / 365 days✅ Passed

✅ BUILD PASSED - All security checks passed

@sunil-lakshmansunil-lakshman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunil-lakshman
sunil-lakshman merged commit 66ff319 into enhc/betaMay 22, 2026
10 checks passed
@sunil-lakshman
sunil-lakshman deleted the enhc/DX-7298 branch May 22, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@OMpawar-21@sunil-lakshman