Skip to content

CL-2062 | +Harshi | Fix skip environment variables option with --vari… - #68

Merged
SakshiKoli-CS merged 9 commits into
developmentfrom
cl-2062
Nov 4, 2025
Merged

CL-2062 | +Harshi | Fix skip environment variables option with --vari…#68
SakshiKoli-CS merged 9 commits into
developmentfrom
cl-2062

Conversation

@SakshiKoli-CS

Copy link
Copy Markdown
Contributor

…able-type flag

dhruvparekh12and others added 8 commits June 11, 2025 14:17
fix: exclude .git folder when generating the zip file for deploying File Upload projects
chore: upgrade package version cli-utilities
Exclude .git folder when generating the zip file for deploying File Upload projects and Upgrade cli-utilites package version
chore: update version in package.json file
Add Nuxt and Remix framework preset options

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a type handling issue in the environment variable import flow where variableType could be either a string or array depending on the input source.

  • Changed variablePreparationType to handle both string and array types
  • Added type guard to normalize string input to array format
  • Added test coverage for string-type command line flag input

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
src/adapters/base-class.tsAdded type annotation and type guard to convert string variableType to array format for consistent processing
src/adapters/base-class.test.tsAdded tests to verify string-type variableType from command line flags is handled correctly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tejas-contentstack
tejas-contentstack previously approved these changes Oct 31, 2025
Chhavi-Mandowara
Chhavi-Mandowara previously approved these changes Nov 3, 2025
Comment threadsrc/adapters/base-class.ts
Comment threadsrc/adapters/base-class.test.ts Outdated

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

anonyda
anonyda previously approved these changes Nov 3, 2025
naeem-shakh-cs
naeem-shakh-cs previously approved these changes Nov 3, 2025
@Chhavi-Mandowara
Chhavi-Mandowara changed the base branch from main to developmentNovember 3, 2025 12:04
@Chhavi-Mandowara
Chhavi-Mandowara dismissed stale reviews from naeem-shakh-cs, anonyda, and themself November 3, 2025 12:04

The base branch was changed.

@Chhavi-Mandowara
Chhavi-Mandowara requested a review from a team as a code ownerNovember 3, 2025 12:04
@Chhavi-Mandowara
Chhavi-Mandowaraforce-pushed the cl-2062 branch 3 times, most recently from ddcdb87 to c89d9efCompareNovember 4, 2025 05:21
@SakshiKoli-CS
SakshiKoli-CS merged commit a6cec1f into developmentNov 4, 2025
6 of 7 checks passed
@SakshiKoli-CS
SakshiKoli-CS deleted the cl-2062 branch November 4, 2025 05:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@SakshiKoli-CS@anonyda@Chhavi-Mandowara@tejas-contentstack@naeem-shakh-cs@AryanBansal-launch@anujachordiya-contentstack@dhruvparekh12@Aravind-Kumar-cstk