Skip to content

fix: use runtime cwd for data-dir flag - #90

Merged
Harshi-Shah-CS merged 1 commit into
developmentfrom
cl-2273
Jan 28, 2026
Merged

fix: use runtime cwd for data-dir flag#90
Harshi-Shah-CS merged 1 commit into
developmentfrom
cl-2273

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

fix: use runtime cwd for data-dir flag

Chhavi-Mandowara
Chhavi-Mandowara previously approved these changes Jan 28, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the data-dir flag's default value was captured at module load time instead of at runtime. The change ensures that process.cwd() is evaluated when the command executes, not when the module is loaded.

Changes:

  • Removed the default: process.cwd() from the data-dir flag definition in the Functions command
  • Added runtime evaluation of process.cwd() in the init() method with fallback logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/commands/launch/functions.ts
@Harshi-Shah-CS
Harshi-Shah-CS requested a review from a teamJanuary 28, 2026 10:34

@dhruvparekh12dhruvparekh12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Harshi-Shah-CS
Harshi-Shah-CS merged commit 9da4813 into developmentJan 28, 2026
5 of 7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the cl-2273 branch January 28, 2026 10:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Harshi-Shah-CS@dhruvparekh12@Chhavi-Mandowara