You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
validate modern tools/callMcp-Param-* headers against request-scoped tool schemas published by the control plane
return JSON-RPC -32020 for a mismatch or missing published schema
forward validated parameter headers unchanged on the outgoing tools/call and protect them from backend header configuration
keep plugin handling unchanged: plugins run after validation and do not cause header reconstruction
The dataplane does not call tools/list, reconstruct headers from arguments, or change RMCP. This PR requires IBM/mcp-context-forge#6348 to publish visibility-filtered schemas keyed by original upstream tool name.
The GitHub composed conformance job still pulls the stock control-plane image and therefore fails to deserialize its pre-#6348 payload (missing field tool_schemas). No dataplane fallback is included; the job will pass once #6348 is merged into that image.
cargo nextest run --locked --workspace (227 passed, 3 skipped)
workspace build, dependency-policy, shear, formatting, generated-schema, and wiki checks
conformance adapter, reporter, and baseline unit tests
control-plane publisher unit tests (26 passed), Ruff, and Black
cross-repo E2E with the official conformance fixture and #6348 publisher: matching plain/Base64 values pass; mismatched, invalid Base64, and missing headers return JSON-RPC -32020
The direct fixture E2E is used because the official server scenario currently reaches the separately baselined stateless tools/list session limitation during setup. Client findings remain limited to the existing four shell-adapter generation IDs.
lucarlig
changed the title
fix: generate SEP-2243 parameter headersfix: require stateless metadata and generate SEP-2243 headersAug 21, 2026
lucarlig
changed the title
fix: require stateless metadata and generate SEP-2243 headersfix: validate and generate SEP-2243 headersAug 21, 2026
The reason will be displayed to describe this comment to others. Learn more.
I don't see how checking the max body size of the message is a part of header validation logic. Ideally, body size validation should be in a separate layer and re-using layers provided by Axum.
This header validation logic only applies to tools. Not sure if using a layer approach is valid as this is going to be executed on all rmcp calls as well as new and old protocols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/callMcp-Param-*headers against request-scoped tool schemas published by the control plane-32020for a mismatch or missing published schematools/calland protect them from backend header configurationThe dataplane does not call
tools/list, reconstruct headers from arguments, or change RMCP. This PR requires IBM/mcp-context-forge#6348 to publish visibility-filtered schemas keyed by original upstream tool name.The GitHub composed conformance job still pulls the stock control-plane image and therefore fails to deserialize its pre-#6348 payload (
missing field tool_schemas). No dataplane fallback is included; the job will pass once #6348 is merged into that image.Stacked on #107. Related: IBM/mcp-context-forge#6256.
Verification
cargo clippy --locked --workspace --all-targets -- -D warningscargo nextest run --locked --workspace(227 passed, 3 skipped)-32020The direct fixture E2E is used because the official server scenario currently reaches the separately baselined stateless
tools/listsession limitation during setup. Client findings remain limited to the existing four shell-adapter generation IDs.