feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat: add hooks system for CLI event interception - #11029

Merged
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service
Mar 4, 2026
Merged

feat: add hooks system for CLI event interception#11029
sestinj merged 11 commits into
mainfrom
nate/cli-hooks-service

Conversation

@sestinj

@sestinjsestinj commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Claude Code-compatible hooks system for the Continue CLI that allows external handlers (shell commands, HTTP endpoints) to intercept and respond to 16 CLI event types
  • Supports regex-based event matching, typed inputs/outputs, sync/async execution, and multi-source config merging from .continue/ and .claude/ directories
  • Includes comprehensive test coverage

Test plan

  • Verify hooks config loading from multiple sources
  • Test command hook execution with stdin JSON piping
  • Validate exit code semantics (0=proceed, 2=block)
  • Confirm async hooks fire without blocking

🤖 Generated with Claude Code


Continue Tasks: ✅ 7 no changes — View all


Summary by cubic

Adds a Claude Code–compatible hooks system to the Continue CLI so external command and HTTP handlers can intercept and influence 17 CLI events. Registers HookService and tightens execution with UTF-8-safe streams, correct env var interpolation, clean EPIPE handling, and ESLint fixes.

  • New Features

    • HookService with fireEvent, reloadConfig, and getCommonFields; exposed via services.hooks.
    • Config merging from ~/.continue, .continue (including settings.local.json), and .claude; supports disableAllHooks.
    • Command/HTTP hooks follow Claude semantics (exit 0/2, JSON parsing); CONTINUE_PROJECT_DIR/CLAUDE_PROJECT_DIR set; async hooks, regex matching, dedup, parallel execution; defaults: 600s command, 30s HTTP.
    • fireHook helpers for common events; documented in AGENTS.md.
  • Bug Fixes

    • Use setEncoding("utf8") for stdout/stderr to avoid multibyte corruption.
    • Fix HTTP header env var interpolation to handle ${VAR} and $VAR forms.
    • Only suppress EPIPE errors on stdin writes; log other stdin errors.
    • Register HookService in the service container and expose via services.
    • React hooks cleanup in useService: memoize reload/deps, remove invalid eslint-disable comment, and skip hookRunner tests on Windows.

Written for commit 8782e38. Summary will update on new commits.

Adds a Claude Code-compatible hooks system that allows external handlers
(shell commands, HTTP endpoints) to intercept and respond to CLI events.
Supports 16 event types with regex-based matching, typed inputs/outputs,
sync/async execution, and multi-source config merging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj requested a review from a team as a code ownerMarch 4, 2026 16:04
@sestinj
sestinj requested review from RomneyDa and removed request for a teamMarch 4, 2026 16:04
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
The fireHook.ts module references services.hooks, which requires the
HookService to be registered in the service container and exposed in
the services object.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dosubotdosubotBot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 4, 2026

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:89">
P2: Using `data.toString()` per chunk corrupts multi-byte UTF-8 characters split across buffer boundaries. Set encoding on the streams so Node's internal `StringDecoder` handles this correctly.
(Based on your team's feedback about setting encoding to "utf8" on stdout/stderr streams instead of using `toString()` per 'data' event.) [FEEDBACK_USED]</violation>
<violation number="2" location="extensions/cli/src/hooks/hookRunner.ts:98">
P1: Missing error handler on `child.stdin` — if the child process closes its stdin pipe before the write completes, the unhandled `'error'` event on the stdin stream can crash the Node.js process.</violation>
<violation number="3" location="extensions/cli/src/hooks/hookRunner.ts:149">
P2: Regex `\$\{?(\w+)\}?` incorrectly matches unbalanced braces (e.g., `$FOO}` consumes the `}` even without an opening `{`). Use alternation to properly handle both `${VAR}` and `$VAR` forms.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 2 commits March 4, 2026 08:13
Fix unused imports, import ordering, and negated condition lint errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a hook command exits before we finish writing to stdin, an EPIPE
error is emitted. Add an error handler to suppress it gracefully.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-aicubic-dev-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/hooks/hookRunner.ts">
<violation number="1" location="extensions/cli/src/hooks/hookRunner.ts:98">
P2: The new stdin error handler ignores every error, not just EPIPE as intended; this masks unexpected write failures.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment threadextensions/cli/src/hooks/hookRunner.ts Outdated
sestinjand others added 7 commits March 4, 2026 08:32
The hookRunner tests use /bin/sh syntax (>&2, single-quote echo, sleep)
that is incompatible with Windows cmd.exe.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use setEncoding("utf8") on stdout/stderr instead of data.toString()
to prevent multi-byte character corruption at buffer boundaries
- Fix env var interpolation regex to use alternation instead of
independent optionals, preventing unbalanced brace matching
- Only suppress EPIPE errors on stdin, log other errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The react-hooks eslint plugin is not configured in the CLI package,
so the disable comment causes an eslint error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sestinj
sestinj merged commit abb1fc0 into mainMar 4, 2026
61 checks passed
@sestinj
sestinj deleted the nate/cli-hooks-service branch March 4, 2026 23:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 4, 2026
@github-actionsgithub-actionsBot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Mar 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XXLThis PR changes 1000+ lines, ignoring generated files.tier 1Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sestinj