Uh oh!
There was an error while loading. Please reload this page.
Add option to update dropdown menu only after async callback is done - #84
Open
SparrowFix wants to merge 3 commits into
Open
Add option to update dropdown menu only after async callback is done#84SparrowFix wants to merge 3 commits into
SparrowFix wants to merge 3 commits into
Conversation
added 3 commits
July 27, 2016 12:45
…k is done On some use cases it can be useful to render the search suggestions after all suggestions are available from synchronus and asynchronus callback of a dataset. So, the flag "updateOnAsync" is introduced to have the possibility to activate the new mode, to render the whole result after asynchronus callback only. If you want to display the whole result only, then this mode can be used now. Also, if you work with asynchronus data only and will not use a pending template, this mode ensures to prevent closing and reopen the dropdown menu on keypress (which can be misinterpreted as an ugly flickering, while the user types something) provokes by the empty or unused synchronus callback.
franklinjavier
commented
Feb 6, 2017
Any update on this? |
jlbooker
commented
Feb 8, 2017
Contributor
@franklinjavier It needs review and resolution of the merge conflicts in |
lenovouser
approved these changes
Feb 8, 2017
lenovouser
left a comment
Contributor
There was a problem hiding this comment.
LGTM if you fix the merge conflicts. Thanks! 👍
franklinjavier
commented
Feb 8, 2017
👍🏼 |
OkayItsMikael
commented
Feb 21, 2017
Any updates here? |
jlbooker
approved these changes
Mar 21, 2017
jlbooker
commented
Mar 21, 2017
Contributor
Just need to look into the conflicts in dataset.js and then this can be merged. |
judowalker
commented
Aug 2, 2017
Will this fix #147? Any estimate on when this will be merged? |
omggga
commented
Dec 25, 2017
Hello there, any news on this task? :< |
franklinjavier
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to refresh suggestion list on DOM only after async callback is done
On some use cases it can be useful to render the search suggestions after all suggestions are available from synchronous and asynchronous callback of a dataset. So, the flag "updateOnAsync" is introduced to have the possibility to activate the new mode, to render the whole result after asynchronous callback only.
If you want to display the whole result only, then this mode can be used now. Also, if you work with asynchronous data only and will not use a pending template, this mode ensures to prevent closing and reopen the dropdown menu on keypress (which can be misinterpreted as an ugly flickering, while the user types something) provokes by the empty or unused synchronous callback.