Update JIRA issues from matching GitHub issues by MorganEPatch · Pull Request #4 · coreos/issue-sync

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch · 2017-07-11T20:10:08Z

This PR builds on #2, and is thus blocked on it.

This PR adds the updateIssue() function, which updates a given JIRA issue from a given GitHub issue's title and description and the project passed in the config. It also sets the custom fields forthe GitHub labels and the time the tool ran. It only updates the fields which have been changed, or returns without doing anything if none of them have changed.

The function does not update the Reporter, Assignees, Issue Type, or Priority. These may be set in a future change. This function also does not update the issue status; this requires walking through the workflow using transitions, and is a much later planned feature.

squat · 2017-07-19T17:22:03Z

+ fields.Description = *ghIssue.Body
+	}
+
+	key := fmt.Sprintf("customfield_%s", ghStatusFieldID)


you should create a constant for the customFieldTemplateString = "customefield_%s" to avoid errors going forward since this is used to heavily.

squat · 2017-07-19T17:24:35Z

+ log.Errorf("Error updating JIRA issue %s: %s", jIssue.Key, err)
+ defer res.Body.Close()
+ body, _ := ioutil.ReadAll(res.Body)
+ log.Debugf("Error body: %s", body)


more descriptive error please, e.g. error reading body from jira update issue request

squat · 2017-07-19T17:30:19Z

+	return nil
+}
+
+func updateIssue(ghIssue github.Issue, jIssue jira.Issue, client jira.Client) error {


These two functions have tons of gotcha's and check lots of different fields. How are you going to test this to make sure you are catching all the cases and correctly identifying changed issues? Please make a func called e.g. areIssuesSame or compareIssue etc that returns a bool if the issues are the same and write a test for it. This function can be easily tested. Now, update updateIssue to only update an issue if the previous function returns false. Also, this way, updateIssue can indiscriminately set all members of the fields struct and send of the request. it isolates concerns

This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

MorganEPatch self-assigned this Jul 11, 2017

MorganEPatch mentioned this pull request Jul 11, 2017
Create comments in JIRA after create and update #6
Merged

squat suggested changes Jul 19, 2017
View reviewed changes

squat approved these changes Jul 20, 2017
View reviewed changes

synchronize command: Update matched issues
19165d5
This commit adds issue updating. It can update the Summary, Description, GitHub labels, GitHub status, and GitHub reporter, as well as changing the last update time.

MorganEPatch merged commit 41fa056 into coreos:masterJul 20, 2017

macpijan pushed a commit to 3mdeb/issue-sync that referenced this pull request Sep 26, 2022
Merge pull requestcoreos#4from indeedeng/add_project_tracking_2
a4311a9
Add project tracking 2

Uh oh!

Conversation

MorganEPatch commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MorganEPatch commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MorganEPatch commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MorganEPatch commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MorganEPatch commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!