') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); update all dependencies by crfeliz · Pull Request #46 · coreos/issue-sync · GitHub
Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

update all dependencies - #46

Open
crfeliz wants to merge 1 commit into
coreos:masterfrom
indeedeng:update_dependencies
Open

update all dependencies#46
crfeliz wants to merge 1 commit into
coreos:masterfrom
indeedeng:update_dependencies

Conversation

@crfeliz

@crfelizcrfeliz commented Apr 22, 2019•
edited
Loading

Copy link
Copy Markdown

#45
Update all dependencies. Add .idea and issue-sync (output of go build) to .gitignore. Specify int64 where necessary.

@crfelizcrfeliz mentioned this pull request Apr 22, 2019
Open
@crfelizCarlos Feliz
issue-45 - upgrade dependencies. Add .idea and issue-sync (output of …
30672ab
…go build) to .gitignore. Specify int64 where necessary.
@crfeliz
crfelizforce-pushed the update_dependencies branch from 2e8f4f5 to 30672abCompareApril 22, 2019 20:50
@crfeliz

crfeliz commented Apr 24, 2019•
edited
Loading

Copy link
Copy Markdown
Author

@squat I know this is quit a large change set. What it boils down to is running a glide upgrade and changing int to int64 in a few places. Could you offer some guidance on how to get this upgrade approved for upstream? I have a few other feature-based changes I hope to push up as well however this upgrade is prerequisite.

@crfeliz

crfeliz commented May 7, 2019

Copy link
Copy Markdown
Author

Bumping this issue. Let me know if there is anything I can do to to get this change review/merged. I know i looks daunting but this is pretty much the result of running glide update and then fixing the few errors int64 related errors. If you have a preferred plan of action for updating dependencies I'd be happy to follow that process.

squat
squat reviewed May 7, 2019
View reviewed changes

@squatsquat left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Two small questions and we can merge!

Comment thread.gitignore

bin/
.idea/
issue-sync

@squatsquatMay 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this should not be here. All binaries should be compiles directly in `bin. If not, we have some build system bug

@crfelizcrfelizMay 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea it currently builds in the same directory as source. I can look into that. I'll remove this from the pr.

Comment thread.gitignore
.glide/

bin/
.idea/

@squatsquatMay 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for some editor files?

@crfelizcrfelizMay 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I use IntelliJ which creates editor files under that directory.

Comment threadlib/comments.go
// matches[0] is the whole string, matches[1] is the ID
matches := jCommentIDRegex.FindStringSubmatch(jComment.Body)
id, _ := strconv.Atoi(matches[1])
id, _ := strconv.ParseInt(matches[1], 10, 64)

@squatsquatMay 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from this PR,but we need to give this module some TLC and check all returned errors.

@crfelizcrfelizMay 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. My upcoming PRs add features as well as more thorough error handling and I'm currently working on unit tests. It might prove difficult to slice the upcoming work into small PRs (I'll do my best obviously) but included in those changes are some minor improvements in various parts of the code.

@squat

squat commented May 11, 2019 via email

Copy link
Copy Markdown
Contributor

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@squatsquatsquat left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crfeliz@squat