Skip to content

docs(known-issues): document early blocking - #222

Open
fzipi wants to merge 6 commits into
mainfrom
chore/add-early-blocking-docs
Open

docs(known-issues): document early blocking#222
fzipi wants to merge 6 commits into
mainfrom
chore/add-early-blocking-docs

Conversation

@fzipi

Copy link
Copy Markdown
Member

what

  • document early blocking problems as known issues

Fixes#221

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
fzipi requested a review from a teamJune 19, 2025 14:14
@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 19, 2025

Copy link
Copy Markdown

Deploying crs-documentation with Cloudflare Pages Cloudflare Pages

Latest commit:e2e4c3a
Status: ✅ Deploy successful!
Preview URL:https://cb78cb5b.documentation-km5.pages.dev
Branch Preview URL:https://chore-add-early-blocking-doc.documentation-km5.pages.dev

View logs

Comment threadcontent/7-known-issues/_index.md Outdated
Comment threadcontent/7-known-issues/_index.md
Comment threadcontent/7-known-issues/_index.md Outdated
Co-authored-by: Xhoenix <86168235+Xhoenix@users.noreply.github.com>
Comment threadcontent/7-known-issues/_index.md Outdated
Comment on lines +18 to +19
> **Enable early execution of phase 1 rules**
> By default, ModSecurity does **not** activate this flag. Phase 1 rules run **after** the request headers are fully read. This flag allows certain phase 1 rules to trigger *earlier*, potentially before the full header set is available.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong way around. @airween? Didn't the issue say they used --disable-request-early?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @theseion is right. I think we should suggest don't use --disable-request-early flag.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Is it just the name, or the behavior completely changes? Can you point me to the docs?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found this one:

Starting with ModSecurity 2.7.0 there are a few important configuration options

  1. --enable-request-early - On ModSecurity 2.6 phase one has been moved to phase 2 hook, if you want to play around it use this option.

But in configure.ac, the logic is in opposite direction:

 if test "$enableval" != "no"; then
request_early="-DREQUEST_EARLY"
MODSEC_EXTRA_CFLAGS="$MODSEC_EXTRA_CFLAGS $request_early"
else
request_early=
fi
],
[
request_early='-DREQUEST_EARLY'

The logic:

  • if the user passes this option, and the value is not no (which equals with --disable-request-early, then feature will be turned ON
  • if the user does not pass this option, then the build script assumes it's necessary and will be turned ON

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @coreruleset/core-developers

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xhoenix Did my best. Can you re-review?

@XhoenixXhoenixFeb 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ModSec Docs conflict with this --disable-request-early flag, and suggest --enable-request-earlyhttps://github.com/owasp-modsecurity/ModSecurity/wiki/Reference-Manual-%28v2.x%29#start-apache-httpd. Maybe the Docs need to be updated.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@airween Do you know the right answer here? Do we need to update the modsecurity docs first, and then this one?

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the --enable-request-early ModSecurity compilation flag in the CRS known issues section, addressing issue #221. The documentation explains why this flag should remain disabled by default and describes the risks associated with enabling it. Additionally, the PR reorganizes the existing known issues with improved formatting using emojis for better visual structure.

Changes:

  • Added comprehensive documentation for ModSecurity's --enable-request-early flag including motivation, technical details, risks, and recommendations
  • Reorganized existing known issues into categorized sections (Apache, ModSecurity, Debian, CRS + ModSecurity, libmodsecurity3)
  • Enhanced visual structure with emoji icons for improved readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadcontent/7-known-issues/_index.md Outdated
Comment threadcontent/7-known-issues/_index.md Outdated
Comment threadcontent/7-known-issues/_index.md
fzipiand others added 2 commits February 6, 2026 19:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for the --enable-request-early compilation flag

5 participants

@fzipi@airween@theseion@Xhoenix