Skip to content

Improve testing - #57

Merged
fgsch merged 7 commits into
mainfrom
fgsch/improve-ci
Nov 26, 2020
Merged

Improve testing#57
fgsch merged 7 commits into
mainfrom
fgsch/improve-ci

Conversation

@fgsch

@fgsch fgsch commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

See individual commits for details.

continue-on-error will not bubble up the error, so fail for now.
@fgsch
fgsch requested a review from fzipi November 26, 2020 12:03
This is only needed in the python 2 case so we don't need to do anything
here.
There are various errors that require a newer version of pytest, which
is incompatible with python2. While we migrate away, limit these tests
to Python 3.9.

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread .github/workflows/ci.yml Outdated
@fgsch fgsch closed this Nov 26, 2020
@fgsch fgsch reopened this Nov 26, 2020
@fgsch
fgsch merged commit c28e3ef into main Nov 26, 2020
@fgsch
fgsch deleted the fgsch/improve-ci branch November 26, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants