Skip to content

Rearrange imports and minor polish - #58

Merged
fgsch merged 2 commits into
mainfrom
fgsch/tidy-up
Nov 26, 2020
Merged

Rearrange imports and minor polish#58
fgsch merged 2 commits into
mainfrom
fgsch/tidy-up

Conversation

@fgsch

@fgsch fgsch commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

SSIA

@fgsch
fgsch requested a review from fzipi November 26, 2020 17:27
@fgsch
fgsch force-pushed the fgsch/tidy-up branch 6 times, most recently from 9d844ab to acc24d4 Compare November 26, 2020 18:09

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, shall we use ' for strings? Right now some of the texts have b', while others have b"

@fgsch

fgsch commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

For consistency, shall we use ' for strings? Right now some of the texts have b', while others have b"

Sure, I can do that in a separate commit too, once I have all the errors fixed.

@fgsch
fgsch force-pushed the fgsch/tidy-up branch 6 times, most recently from ebf38ab to ee2e5e2 Compare November 26, 2020 21:27

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fgsch
fgsch merged commit 60c727a into main Nov 26, 2020
@fgsch
fgsch deleted the fgsch/tidy-up branch November 26, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants