Skip to content

fix(encoding): remove encoding for base64 encoded request - #59

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
fzipi:remove-encoding
Mar 24, 2021
Merged

fix(encoding): remove encoding for base64 encoded request#59
fzipi merged 1 commit into
coreruleset:mainfrom
fzipi:remove-encoding

Conversation

@fzipi

@fzipi fzipi commented Mar 23, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

@fzipi
fzipi force-pushed the remove-encoding branch 3 times, most recently from ec525f8 to 0149237 Compare March 23, 2021 23:59
@fzipi

fzipi commented Mar 24, 2021

Copy link
Copy Markdown
Member Author

Encoded request in test has multiple \\:

R0VUIC8gSFRUUC8xLjFcclxuSG9zdDogZXhhbXBsZS5jb21cclxuXHJcbg== 

Gets you GET / HTTP/1.1\\r\\nHost: example.com\\r\\n\\r\\n.

@fzipi
fzipi marked this pull request as ready for review March 24, 2021 00:07
@fzipi
fzipi requested a review from fgsch March 24, 2021 00:14
Comment thread test/integration/test_http.py Outdated
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
fzipi force-pushed the remove-encoding branch from 0149237 to bb57cac Compare March 24, 2021 00:43

@fgsch fgsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi
fzipi merged commit 686beb7 into coreruleset:main Mar 24, 2021
@fzipi
fzipi deleted the remove-encoding branch March 24, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants