Skip to content

Updated dependencies - #69

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
theseion:performance-improvement-dependency-updates
Mar 9, 2022
Merged

Updated dependencies#69
fzipi merged 1 commit into
coreruleset:mainfrom
theseion:performance-improvement-dependency-updates

Conversation

@theseion

@theseion theseion commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Added test build for Python 3.10

Split from PR #66, part 2

@theseion
theseion requested review from fgsch and fzipi March 4, 2022 07:49
@theseion theseion mentioned this pull request Mar 4, 2022

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this one updates dependencies, but also tests. Test should be only in the next PR.

@theseion

theseion commented Mar 6, 2022

Copy link
Copy Markdown
Contributor Author

I did that so the PR checks would run through and to show, that the change doesn't affect the tests. Do you still want me to change it?

Added test build for Python 3.10

Split from PR coreruleset#66, part 2
@theseion
theseion force-pushed the performance-improvement-dependency-updates branch from b6f5b7b to 8872cab Compare March 9, 2022 17:35
@theseion

theseion commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@fzipi @fgsch this is the next one.

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@fzipi
fzipi merged commit 2ea3270 into coreruleset:main Mar 9, 2022
@theseion
theseion deleted the performance-improvement-dependency-updates branch March 10, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants