Skip to content

Improved test support - #70

Merged
fzipi merged 3 commits into
coreruleset:mainfrom
theseion:performance-improvement-improved-test-support
Mar 10, 2022
Merged

Improved test support#70
fzipi merged 3 commits into
coreruleset:mainfrom
theseion:performance-improvement-improved-test-support

Conversation

@theseion

@theseion theseion commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Support creation of log markers.

Split from PR #66, part 3

@theseion
theseion requested review from fgsch and fzipi March 4, 2022 08:08
@theseion theseion mentioned this pull request Mar 4, 2022
Give log checker more information, so it can produce identifiable log markers
@theseion
theseion force-pushed the performance-improvement-improved-test-support branch from c5c5f66 to bdfb4b7 Compare March 10, 2022 20:02

@fzipi fzipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you don't mind, I probably squash the last two commits for a cleaner history.

@fzipi

fzipi commented Mar 10, 2022

Copy link
Copy Markdown
Member

Oh, I can't do it using the GH interface. Can you squash those @theseion ?

@theseion

Copy link
Copy Markdown
Contributor Author

Damn, you're fast 😄. Sure, squash ahead.

@theseion

Copy link
Copy Markdown
Contributor Author

Apparently, I don't have write access to the repo, so no, I can't perform the merge / squash, sorry.

@fzipi

fzipi commented Mar 10, 2022

Copy link
Copy Markdown
Member

No, I mean you last two commits. The last one fbca174 can be squashed with bdfb4b7.

@theseion
theseion force-pushed the performance-improvement-improved-test-support branch from fbca174 to 6ffa312 Compare March 10, 2022 20:22
@fzipi
fzipi merged commit 8204a00 into coreruleset:main Mar 10, 2022
@theseion
theseion deleted the performance-improvement-improved-test-support branch March 10, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants