Skip to content

KAN-346 follow-up: scope the spec's Revision 1 assertion to the history dialog#126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corrin merged 1 commit into from
Aug 31, 2026
Merged

KAN-346 follow-up: scope the spec's Revision 1 assertion to the history dialog #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontend/tests/e2e/job/copy-estimate-to-quote.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -133,9 +133,11 @@ test.describe.serial('copy estimate to quote', () => {
// The archived quote stays visible: the Revisions history holds what the
// replace displaced, including the line it archived.
await autoId(page, 'JobQuoteTab-revisions').click()
await expect(page.getByText('Quote Revisions History')).toBeVisible({ timeout: 10000 })
await expect(page.getByText('Revision 1')).toBeVisible()
const dialog = page.getByRole('dialog')
await expect(dialog.getByText('Quote Revisions History')).toBeVisible({ timeout: 10000 })
// Scoped to the dialog: the tab header also says "Revision 1" (the live
// CostSet rev), which is a different number than the archive's.
await expect(dialog.getByText('Revision 1')).toBeVisible()
await expect(dialog.getByText('Straightening charge')).toBeVisible()
await page.keyboard.press('Escape')
})
Expand Down
Loading