HOTFIX KAN-353: kanban job-number search returns nothing - #134

Open
corrin wants to merge 1 commit into
productionfrom
hotfix/KAN-353-kanban-numeric-search
Open

HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom
hotfix/KAN-353-kanban-numeric-search

Conversation

@corrin

@corrincorrin commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.

Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.

The bug

Typing a job number into the kanban search box put "9"7537 in the box and returned no results.

The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:

typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓

Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.

Also included

Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.

Backend needs no change: it has served the archived column, its label and its diffs all along.

Risk

  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.

Verification

  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.

Jira: https://docketworks.atlassian.net/browse/KAN-353
Same change is already merged to main as #133.

🤖 Generated with Claude Code

https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7

@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai

coderabbitaiBot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@corrin
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
HOTFIX KAN-353: kanban job-number search returns nothing - #134
Open
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Open
HOTFIX KAN-353: kanban job-number search returns nothing#134
corrin wants to merge 1 commit into
productionfrom 
hotfix/KAN-353-kanban-numeric-search
Conversation
@corrin
@corrincorrin
commented
Sep 2, 2026

Copy link


Copy Markdown

Owner
Emergency hotfix, based directly on production. Frontend only — zero migrations, no dependency changes, no external-API changes.
Deliberately NOT the main→production release. This carries only the kanban search fix, so it can go out without the release's schema rename, Places API switch or payroll sync changes.
The bug
Typing a job number into the kanban search box put "9"7537 in the box and returned no results.
The search box READ the raw query string (location.searchStr) but WROTE through navigate() — TanStack's stringifier. The default stringifier JSON-quotes any value that parses as JSON, so a job number goes out as ?q=%2297537%22 and comes back as the literal "97537", quote characters included. Verified against the installed router, not inferred:
typedURL writtenraw read (what the box got)
97537?q=%2297537%22"97537" ← literal quotes
smith?q=smithsmith ✓
Only values that parse as JSON are affected — which is job numbers, i.e. the main search path. Both sides now read the parsed value through one normaliser. A number is also coerced rather than dropped, so a shared ?q=97537 link filters the board instead of rendering an unfiltered one under a filled-in box.
Also included
Archived gets a board column. It was never rendered in v2, hiding ~95% of the jobs the board knows about (2287 archived against 117 elsewhere), which is why searching for an old job failed twice over. Adding it to OFFICE_COLUMN_IDS is the whole lever — the grid, the reconciliation feed and every cache writer derive from that array. The three special cases built on the old premise go with it, notably updateStatus, which called removeJob and so deleted a card the user asked to archive.
Backend needs no change: it has served the archived column, its label and its diffs all along.
Risk
  • No migrations. No schema change, no downtime beyond the normal restart.
  • Frontend only; the backend is byte-identical to what production runs today.
  • Rollback is a code-only revert — unlike the main→production release, which requires reversing migrations.
  • Perf: one extra parallel column query on mount, index-served, ~31KB gzipped against the 100KB guard. DOM goes 117 → ~317 cards. Nothing on the drag/reconciliation hot path changed.
Verification
  • Unit: full suite green; each new test confirmed to fail against the pre-fix code first (expected '"9"' to be '9'; expected [] to deeply equal ['archived']).
  • E2E (run 6v3f3dsb, same commit content on the main-based branch): all 3 new kanban-search specs pass, plus all 17 existing kanban specs including the drag-and-search interactions the new column could have broken.
  • The E2E spec types with pressSequentially rather than fill() — fill() is one atomic change event, which is why the existing specs never caught this.
Jira: https://docketworks.atlassian.net/browse/KAN-353

Same change is already merged to main as #133.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@corrin@claude
fix: KAN-353 — job-number search stops corrupting itself, and Archive…
c6c8d8f
…d gets a column
Two independent defects on one journey, "find job 97537".
The search box read the RAW query string (location.searchStr) but wrote
through navigate(), i.e. TanStack's stringifier. The default stringifier
JSON-quotes any value that parses as JSON, so a job number went out as
?q=%2297537%22 and came back as the literal `"97537"`. Typing 9, pausing past
the 300ms debounce, then typing the rest therefore produced `"9"7537` in the
box and searched for a string no job carries. Both sides now read the parsed
value through one normaliser; a number is coerced rather than dropped, so a
hand-typed or shared ?q=97537 filters the board instead of silently rendering
an unfiltered one.
Archived was never a column in v2 — omitted on a planning brief's unexamined
premise, recorded in no ADR — which hid ~95% of the jobs the board knows about
(2287 archived against 117 elsewhere), a set that grows nightly as
auto_archive_service moves completed jobs into it. Adding it to
OFFICE_COLUMN_IDS is the whole lever: the grid, the reconciliation feed and
every cache writer already derive from that array. The three special cases
built on the old premise go with it, notably updateStatus, which called
removeJob and so DELETED a card the user asked to archive.
The backend needed no change: it has served the archived column, its label and
its diffs all along.
Decisions taken with the owner: Archived obeys the staff filter like every
other column (an exempt column that stayed full while its neighbours emptied
would read as the filter having failed), and it uses the same COLUMN_MAX_JOBS
as everything else rather than a second ceiling to reason about.
Perf posture: one extra parallel column query on mount, index-served by
Index(status, priority), ~31KB gzipped against the 100KB E2E wire guard. The
real cost is DOM — 117 to ~317 mounted JobCards, with no virtualization on the
board. Nothing on the drag or reconciliation hot path changed.
Tests: the unit specs were confirmed to FAIL against the pre-fix code and pass
after (the box round-trip, the numeric link, and the archive-from-drawer move).
The E2E spec types with pressSequentially rather than fill() — fill() is one
atomic change event, which is exactly why the existing kanban specs never saw
this.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012KsKjSzg9umSt7ad4NHEg7
@coderabbitai
coderabbitaiBot
commented
Sep 2, 2026

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Team
Run ID: 00b24344-b1aa-4880-90f8-94dbb250b491
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@corrin