Skip to content

Update django requirement from <6.1,>=6.0 to >=6.0,<6.2 - #54

Merged
corrin merged 1 commit into
mainfrom
dependabot/pip/django-gte-6.0-and-lt-6.2
Aug 10, 2026
Merged

Update django requirement from <6.1,>=6.0 to >=6.0,<6.2#54
corrin merged 1 commit into
mainfrom
dependabot/pip/django-gte-6.0-and-lt-6.2

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubAug 9, 2026

Copy link
Copy Markdown
Contributor

Updates the requirements on django to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [django](https://github.com/django/django) to permit the latest version.
- [Commits](django/django@6.0...6.1)
---
updated-dependencies:
- dependency-name: django
dependency-version: '6.1'
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Aug 9, 2026
@corrin
corrin merged commit 528c6af into mainAug 10, 2026
2 checks passed
@dependabot
dependabotBot deleted the dependabot/pip/django-gte-6.0-and-lt-6.2 branch August 10, 2026 09:53
corrin added a commit that referenced this pull request Aug 11, 2026
PR #54 (main) widened pyproject.toml's django specifier to
>=6.0,<6.2 but never regenerated the matching uv.lock, which still
recorded <6.1 in its requires-dist metadata. Every `uv run` this
session silently self-corrected the lock locally; committing that
fix rather than leaving a lockfile permanently out of sync with the
manifest it's supposed to pin.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
corrin added a commit that referenced this pull request Aug 11, 2026
* Purchasing PO create/list/detail: po-created-by green
PoCreatePage (CompanyLookup + reference + save -> 201 redirect),
PoListPage, PoDetailPage with PoSummaryCard (created-by input,
reference autosave, status select), usePoLines over the single PATCH
endpoint, and the missing 'po' concurrency invalidator so 412/428
recovery actually refetches. Ports createTestPurchaseOrder +
waitForPoAutosave and the po-created-by spec.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* PO lines grid: create-purchase-order green
PoLinesTable as the third grid on the useReactTable + useDraftRows
pattern (phantom row, no add-line button, row-exit draft commit —
unit-cost stays the row's last focusable cell so the spec's Tab exits
the row). ItemSelect generalised for stock-only consumers (optional
jobId/line, label + wrapper overrides; labour-rates query gated on
jobId presence only, since textOnly labels need rate names). Inline
JobSelect over purchasing_all_jobs_retrieve — the unfiltered endpoint
v1's PO page uses, because fresh jobs are draft and the filtered
sibling excludes them. Spec ported with the autosave waiter armed
before the pick/status clicks (v2 saves immediately; v1's debounce is
what made arm-after work).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Stock page: stock-search green
Spec-lean StockPage: full active-stock list on load, 300ms-debounced
server FTS from 3 characters, enabled-gated so clearing the box
renders the cached list with no /search/ request.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Rewrite-status: purchasing slice recorded (29 of 40)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Unit tests for PO line draft rules and JobSelect filtering
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Unify the table layer: shared DataTable/ListTable, no cross-domain imports
The purchasing slice's PoLinesTable was about to become a third
hand-rolled grid emitting the DataTable-row-N/data-grid-* contract
inline. features/shared/DataTable.tsx is now the one owner of that
contract; SmartTimesheetTable, CostLineGrid and PoLinesTable all
render through it.
Auditing further found the same pathology in the plain list pages:
PoListPage and StockPage (both new this slice) had copied
CompaniesListPage's table shell and loading/error/retry block
verbatim, taking an existing duplicate (also in WipReportPage) from
2 instances to 4. features/shared/ListTable.tsx is the one owner of
that block instead -- deliberately separate from DataTable, since it
has no react-table dependency and forcing static lists through
column-def machinery would be indirection, not rigor. A hand-rolled
debounce-into-query-state pattern in CompaniesListPage and StockPage
is now features/shared/useDebouncedValue.ts (KanbanSearchInput keeps
its own URL-driven debounce -- a different concept).
ItemSelect, the decimal helpers and the Save-failed badge move to
features/shared/ because purchasing consumed them cross-domain -- a
domain feature is not a library.
ADR 0039 strengthened: unification is never deferred, shared concepts
get shared homes, the bar is reference quality.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Review fixes: QueryState primitive, item-label bug, company relocated
Adversarial review on the branch found the ListTable audit had stopped
short: JobMovementReportPage and CompanyDetailPage hand-rolled the same
loading/error/retry block ListTable was built to own (6 real instances,
only 4 fixed). Split the block itself out as
features/shared/QueryState.tsx -- the pending/error gate alone, no
table -- so it fits pages that show something other than a table too.
ListTable now composes QueryState instead of duplicating it. PoDetailPage,
CostLineGrid, JobMovementReportPage and CompanyDetailPage all render
through it.
Fixed: PoLinesTable's item-picker label read `item_code ?? 'Select Item'`
with no description fallback, so a bound stock item with a null code
(nullable, v1 parity) misread as unbound. Now poLineItemLabel() in
lines.ts, unit-tested.
Moved features/company to features/shared/company: it was already
cross-imported by features/job (JobCreatePage, JobSettingsTab) before
this slice added a third importer (purchasing/PoSummaryCard) -- it never
had a route of its own, a shared widget library in a domain-shaped box.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* ADR 0039: name the deadline-vs-duplicate resolution explicitly
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Docs: Slice 3 (SSE + serving model) is MUST before cutover, not deferred
Reversed 2026-08-11. The 2026-08-10 record said SSE ships with the
production-serving decision, filed under "Post-cutover -- decided,
deliberately NOT before 15 August." That was overturned: racing bad
architecture into production defeats the point of the rewrite
(non-negotiable #3 in the Cutover section), and the interim polling
shape plus the un-runnable apps/xero/sync_stream.py view are exactly
that. Slice 3 -- live updates done properly (serving model fix + SSE
ticker + discard the interim shortcuts) moves to its own MUST-tier
section with a milestone checkbox, and every stale "deferred
post-cutover" cross-reference in the file is corrected. The
purchasing-slice PR is unaffected -- it is unrelated and merges as
planned; this correction only fixes the durable record for the next
session.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Third review pass: 4 more QueryState conversions; rewrite-status cleanup
QueryState grew optional loadingNode/errorNode override props so a
spinner-based caller keeps its visual shell instead of losing it to
the plain-text default. JobFinishTab, DailyOverviewPage, and both
gates in TimesheetEntryPage's EntryWorkspace now render through it.
XeroQuoteCard, JobInvoiceCard and JobSettingsTab's pay-item field stay
excluded -- richer branching than binary success/fail, not the
page-level gate QueryState owns. TimesheetEntryPage's own outer gate
stays as guard-clause `if` returns, matching CLAUDE.md's stated
preference rather than converting to a shape that would abandon it.
Also: rewrite-status.md's narration of "review round found X, we
fixed Y" replaced with what the outcomes actually are -- which shared
component owns which contract, which sites are deliberately excluded
and why, which constraints a future change must respect. And the
Cutover section now states the actual two-question go/no-go criteria
(functional parity, proxied by MUST-tier E2E; materially better
architecture, judged directly) rather than only the E2E proxy, with
the honest fallback (abort and stay on v1) stated explicitly.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Address CodeRabbit review: real bugs and comment cleanup
- CompaniesListPage/JobFinishTab: QueryState was passed the raw
isError, breaking the first-load-only rule the other converted
sites already follow -- a background refetch failure was
unmounting already-rendered content instead of leaving it on
screen.
- JobSelect: closing the picker without a selection (blur or
Escape) left `editing` true forever, so the input kept showing
the abandoned search term instead of reverting to the bound job;
the blur timer was untracked and could fire a state update after
unmount. Also added keyboard selection (arrow keys + Enter,
role=listbox/option, aria-activedescendant) -- the dropdown was
mouse-only.
- PoListPage: the row was reachable only by mouse click; added a
real Link on the PO number cell, matching CompaniesListPage's
existing pattern.
- decimal.ts: parseDecimalInput accepted anything Number() parses,
including hex/octal/binary literals and bare exponents, and sent
them to the wire verbatim as garbage Decimal strings. Validates
fixed-point syntax explicitly now.
- Stale features/company/* paths in rewrite-status.md's build-order
table, left behind by the features/shared/company move.
- Comments narrating port history or test intent rewritten to state
the rejected alternative and the constraint (ADR 0043) in
ItemSelect, SaveFailedBadge, CreateCompanyModal, CompanyLookup;
two flagged sites (the E2E-repair-loop comment, the sonner test
comment) were already compliant and left as-is.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Fix uv.lock/pyproject.toml desync on the django constraint
PR #54 (main) widened pyproject.toml's django specifier to
>=6.0,<6.2 but never regenerated the matching uv.lock, which still
recorded <6.1 in its requires-dist metadata. Every `uv run` this
session silently self-corrected the lock locally; committing that
fix rather than leaving a lockfile permanently out of sync with the
manifest it's supposed to pin.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Gitignore the root-level test-results/ Playwright writes too
frontend/test-results/ was covered; run_e2e.sh's Playwright
invocation also writes artifacts relative to the repo root in some
invocations, leaving an untracked test-results/ dangling after every
E2E run.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
* Fix the actual bug behind the stray root test-results/: cwd-relative config
playwright.config.ts resolved .env.test, testDir, outputDir and the
html reporter's folder relative to process.cwd(). Any invocation
whose cwd wasn't frontend/ (npm --prefix from the repo root, a bare
npx playwright test) silently missed .env.test -- dropping
E2E_TEST_USERNAME/PASSWORD with no error -- or wrote artifacts to
the wrong location instead of erroring loudly, which is how a
root-level test-results/ kept reappearing. Anchored every one of
these to import.meta.dirname instead: verified from an unrelated
cwd, .env/.env.test still resolve correctly and no stray directory
gets created anywhere. The root-level gitignore entry from the
previous commit stays as a defensive backstop, but this is the real
fix.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WENcwU8rC6o7bxuHL6md2L
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filepythonPull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@corrin