Uh oh!
There was an error while loading. Please reload this page.
Gracefully close server connections on SIGTERM. - #11
Conversation
kainosnoema
commented
Jan 26, 2016
This will only help if the connection closes in < 10s right? Long downloads may take several minutes. This helps, just not a whole lot. We may want to look into server buffering in Nginx to see if that lets us close the server connection before the client is finished receiving data. Otherwise the only other alternative is to do proper graceful restarts by sharing a UNIX socket. |
kainosnoema
commented
Jan 26, 2016
LGTM |
skewart
commented
Jan 26, 2016
I think your assessment of the situation is correct. Honestly, there are a number of things that I'm not entirely.
|
e2e3206 to
9aeba7dComparekainosnoema
commented
Jan 26, 2016
|
skewart
commented
Jan 26, 2016
👍 |
skewart
commented
Jan 26, 2016
To do the forking with the unix socket, it sounds like you'd need more than one or two lines of logic for that. I'm thinking there's probably a module for that. (maybe forever?) I'll look into it. |
This should make it a little safer to restart the server.
relevant:
http://joseoncode.com/2014/07/21/graceful-shutdown-in-node-dot-js/
expressjs/express#1366