Uh oh!
There was an error while loading. Please reload this page.
Add missing Repository parsing methods - #478
Open
msosnicki wants to merge 1 commit into
Open
Conversation
msosnickiforce-pushed
the
repository-parsers
branch
from
August 10, 2026 08:10
f511029 to
d4aefd3Comparekubukoz
approved these changes
Aug 12, 2026
Gedochao
commented
Aug 21, 2026
@alexarchambault any chance we could push this? it'd actually come in use in Scala 3 REPL. |
| return ApiHelper.parseRepository(input); | ||
| } | ||
| public static List<Repository> repositories(List<String> inputs) { |
There was a problem hiding this comment.
Suggested change
| publicstaticList<Repository> repositories(List<String> inputs) { | |
| publicstaticList<Repository> repositories(List<String> inputs) throwsRepositoryParsingError{ |
There was a problem hiding this comment.
It'd also be nice to add a test in interface-test to enforce RepositoryParsingError is catchable from Java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, in smithy4s repo, we switched from
coursier-coretocoursier-interface. During the migration we were missing methods for parsingRepositoryobjects, so some portions of the code had to be inlined temporarily on smithy4s side (see this PR: disneystreaming/smithy4s#1994).This PR is an attempt to close that gap.