Modernize process management with async I/O and cross-platform improvements by mikecovlee · Pull Request #3 · covscript/covscript-process

mikecovlee · 2026-06-17T11:19:22Z

This pull request introduces comprehensive improvements to the build system, CI pipeline, and project documentation for the CovScript process extension. The main enhancements include integrating libuv as a static dependency, adding platform-aware CI workflows for both CovScript release and nightly channels, and providing detailed project guidance for contributors and AI assistants. These changes collectively ensure robust cross-platform compatibility, consistent SDK/ABI handling, and clearer contribution practices.

Build system and dependency integration:

Integrated libuv as a static library via a new submodule (third_party/libuv), updated CMakeLists.txt to build and link it, and addressed GCC 14 compatibility issues on MinGW. [1][2]
Refactored source file lists and target properties in CMakeLists.txt for platform-specific builds and improved handling of include/link directories and compiler definitions.

Continuous Integration (CI):

Added a cross-platform GitHub Actions workflow (.github/workflows/ci.yml) that builds and tests the extension on Linux, macOS, and Windows (MinGW-w64), against both CovScript release and nightly channels. The workflow also builds CovScript from source and runs both script and C++ unit tests.

Documentation and contributor guidance:

Added .github/copilot-instructions.md and CLAUDE.md to provide project-specific constraints and instructions for AI assistants and contributors, covering module naming, build/test practices, SDK/ABI compatibility, and API design principles. [1][2]

Testing enhancements:

Introduced an optional C++ unit test target (test_uv_fs) in CMakeLists.txt to exercise UV wrapper code paths not reachable from scripts, and integrated its execution into the CI workflow. [1][2]

- Implemented process management functions for Windows in `process_win32_wait.cpp`, including wait, terminate, check exit status, and send signals. - Added various test scripts to validate process execution, asynchronous file handling, and output redirection. - Created unit tests for process functionalities, ensuring robust error handling and expected behavior across different scenarios. - Included tests for both Linux and Windows environments to ensure cross-platform compatibility.

mikecovlee · 2026-06-17T11:22:46Z

@copilot 请修复 CI 失败的问题

… improvements

…work support

…nd clean up related code

…sors - Introduced `test_fiber.csc` to validate process operations within fibers, including wait, communicate, and kill functionalities. - Added `test_stream.csc` to test file stream accessors, ensuring compatibility with standard library iostream behavior. - Updated `test_unit.csc` to enhance process wait and exit code checks, including timeout semantics and stream accessors. - Improved exception handling and validation checks across all tests to ensure robustness and reliability.

… and lifecycle handling

…bility

- Updated the `file` class in `file.hpp` to improve readability and maintainability by restructuring comments and code formatting. - Removed unnecessary forwarding headers for `stream` and `string`. - Enhanced the `async_work` structure in `process.hpp` for better clarity and organization. - Improved error handling and code structure in `process_unix.cpp` and `process_win32.cpp`, including better management of command-line arguments and environment variables. - Refined the polling mechanism for child processes in `process_unix_wait.cpp` to utilize `std::optional` for clearer exit status handling. - General code cleanup and formatting adjustments across multiple files to adhere to coding standards.

…shell usage in tests

Copilot

Pull request overview

This PR rewrites the covscript-process extension around a unified libuv-backed async backend, updates the build system to build libuv as a static dependency, and refreshes the public CNI/C++ API docs plus CI/test coverage to match the new behavior.

Changes:

Integrates libuv (as a git submodule + static build) and updates platform process creation/waiting logic to support async waits, better quoting (Windows), and kill-tree semantics.
Adds a new file_t abstraction with async file I/O (process.async.fstream, file_t.read/write/flush, stream accessors) and expands the CNI API surface (wait_poll, wait_with, communicate, etc.).
Adds comprehensive CovScript test suites and a cross-platform GitHub Actions CI workflow running them on Linux/macOS/Windows.

Reviewed changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`CMakeLists.txt`	Builds libuv from `third_party/libuv` and links it into the extension; modernizes target setup/includes.
`process.cpp`	Major CNI rewrite: adds fiber-aware waits, `process.async` loop control, and async `file_t` methods via libuv.
`src/process.cpp`	Adjusts cross-platform process pipe/redirect setup to support inherited stdio and merge semantics.
`src/process_win32.cpp`	Reworks Windows process creation: handle inheritance, env block build, MSVCRT-correct quoting.
`src/process_win32_wait.cpp`	Implements Windows wait/kill/kill-tree and reliable `has_exited()` check.
`src/process_unix.cpp`	Reworks Unix fork/exec and FD cleanup strategy; adds process group setup for kill-tree.
`src/process_unix_wait.cpp`	Adds Unix wait/timeout/has_exited/kill-tree implementations using `waitid` + nanosleep polling.
`src/core.cpp`	License header refresh + formatting changes.
`include/mozart++/mpp_system/file.hpp`	Adds `mpp::file` wrapper + `open_file()` factory for async I/O + redirects.
`include/mozart++/file`	New forwarding header to `mpp_system/file.hpp`.
`include/mozart++/mpp_foundation/io.hpp`	Formatting and small refactors for fd utilities/pipes.
`include/mozart++/mpp_foundation/fdstream.hpp`	Improves write robustness (chunking) and formatting updates.
`include/mozart++/mpp_core/*`	Formatting/refactor updates (type traits, function parsing, exceptions, event emitter).
`README.md`	New project overview, build/test instructions, and API usage notes.
`CNI_API.md` / `CXX_API.md`	Full API documentation rewrite for the new surfaces/semantics.
`tests/test*.csc`	Adds/updates regression tests covering process waits/communicate, fibers, async fs, redirects, streams.
`.github/workflows/ci.yml`	New cross-platform CI building CovScript + extension and running all test suites.
`.github/copilot-instructions.md` / `CLAUDE.md`	Contributor/AI assistant guidance and project constraints.
`.gitmodules`	Adds libuv submodule definition.
`.gitignore`	Adds ignores for build outputs and temp artifacts used by tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…cess management

…rectly

Copilot

Pull request overview

Copilot reviewed 38 out of 39 changed files in this pull request and generated 6 comments.

…escriptor handling and environment variable parsing

Copilot

Pull request overview

Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.

…ous file system wrapper, covering scenarios such as no deadline, zero deadline, and large file writes.

…asize backward compatibility and supplement the implementation layer description.

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.

…d error handling to CI scripts, and updated the README to include git submodule initialization instructions.

Copilot

Pull request overview

Copilot reviewed 41 out of 42 changed files in this pull request and generated 3 comments.

+#include <uv.h>
+
+#include <chrono>
+#include <thread>
+


Copilotstarted work on behalf of mikecovlee June 17, 2026 11:23 View session

Copilotfinished work on behalf of mikecovlee June 17, 2026 11:30

mikecovlee force-pushed the modernization branch from 0a84277 to e1e1e07Compare June 17, 2026 11:33

fix: register third_party/libuv as git submodule (v1.52.1)
154abe6

covscript deleted a comment from CopilotAIJun 17, 2026

mikecovlee added 3 commits June 17, 2026 19:59

refactor: remove unused signal handling and shell enabling code
fbb65a0

feat: enhance process management with kill_tree support and async I/O…
d9e8927
… improvements

feat: add project guidance and improve process management with async …
2ea466e
…work support

mikecovlee changed the title ~~Add Windows process management support and comprehensive tests~~Rewrite with uv backendJun 18, 2026

mikecovlee added 8 commits June 18, 2026 10:48

fix: ensure proper file closure on Windows in uv_fs_complete function
06789db

feat: update platform detection to use system.is_platform_windows() a…
1c4eeee
…nd clean up related code

feat: refactor file and process classes for improved state management…
46d4da3
… and lifecycle handling

feat: update shell usage in tests for consistency and clarity
14e8cbc

feat: update CI workflow and test commands for cross-platform compati…
8726306
…bility

feat: update CNI API and README for builder method changes; refactor …
f031321
…shell usage in tests

mikecovlee requested a review from Copilot June 24, 2026 07:45

Copilotstarted reviewing on behalf of mikecovlee June 24, 2026 07:46 View session

CopilotAI reviewed Jun 24, 2026
View reviewed changes

Comment threadprocess.cpp Outdated
Comment threadsrc/process_win32.cpp
Comment threadsrc/process_win32.cpp
Comment threadsrc/process_unix.cpp Outdated
Comment threadinclude/mozart++/mpp_system/file.hpp
Comment threadinclude/mozart++/mpp_system/file.hpp
Comment threadCNI_API.md

mikecovlee added 2 commits June 25, 2026 09:20

feat: improve CNI API documentation and enhance error handling in pro…
34179f1
…cess management

feat: enhance close_all_descriptors for Linux by handling fail_fd cor…
7c59298
…rectly

mikecovlee requested a review from Copilot June 25, 2026 01:49

Copilotstarted reviewing on behalf of mikecovlee June 25, 2026 01:49 View session

CopilotAI reviewed Jun 25, 2026
View reviewed changes

Comment threadsrc/process_win32.cpp
Comment threadsrc/process_win32.cpp
Comment threadsrc/process_win32.cpp
Comment threadsrc/process_unix.cpp
Comment threadsrc/process_unix_wait.cpp
Comment threadsrc/process_unix_wait.cpp

feat: enhance process management for Unix and Windows; improve file d…
ff7055e
…escriptor handling and environment variable parsing

mikecovlee requested a review from Copilot June 25, 2026 02:39

Copilotstarted reviewing on behalf of mikecovlee June 25, 2026 02:39 View session

Remove unused codes
d704fb7

mikecovlee requested a review from Copilot June 26, 2026 09:03

Copilotstarted reviewing on behalf of mikecovlee June 26, 2026 09:04 View session

CopilotAI reviewed Jun 26, 2026
View reviewed changes

Comment threadprocess.cpp
Comment threadprocess.cpp
Comment threadCNI_API.md

mikecovlee added 2 commits June 29, 2026 11:24

Add C++ unit tests to verify the functionality of the libuv asynchron…
f48f25d
…ous file system wrapper, covering scenarios such as no deadline, zero deadline, and large file writes.

The CNI script layer interface documentation has been updated to emph…
45c041e
…asize backward compatibility and supplement the implementation layer description.

mikecovlee requested a review from Copilot June 29, 2026 03:33

Copilotstarted reviewing on behalf of mikecovlee June 29, 2026 03:33 View session