Uh oh!
There was an error while loading. Please reload this page.
Ignore copy/move constructors for function naming checks - #4134
Conversation
firewave
commented
May 25, 2022
Thanks for your contribution. Please also add a unit test for this to Please be aware that those are currently not part of the CI. Also please ignore all existing failures - they are known and need to be addressed. More about that in #3715. |
firewave
commented
May 26, 2022
Thanks. I also finally got the PR which adds the tests to the CI ready. I think we should get that in first before merging this. BTW how do you want to be credited as in the |
firewave
commented
May 31, 2022
Please rebase - the tests are now run in the CI again. |
e80932a to
b2adc30CompareAlon-Alexander
commented
May 31, 2022
Regarding the |
Currently, move/copy constructors are checked as function names.
For example, if someone does not name their functions with the same standard as their class names, the tool will report an error.
This fix makes the function name-checking ignore both copy and move constructors.