Uh oh!
There was an error while loading. Please reload this page.
Add std::*begin and std::*end cfg - #4796
Merged
firewave merged 18 commits intoMar 9, 2023
Merged
Conversation
Ashimaru
marked this pull request as draft
February 16, 2023 20:04
Uh oh!
There was an error while loading. Please reload this page.
Ashimaru
marked this pull request as ready for review
February 20, 2023 15:59
Ashimaru
commented
Feb 20, 2023
ContributorAuthor
Seems like there was CI issue, could someone trigger rerun? |
danmar
commented
Feb 24, 2023
Collaborator
I triggered a new run. |
chrchr-github
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we do not support overloads - I am a little worried about std::begin on arrays where outcome is interpreted as interator instead of pointer