Uh oh!
There was an error while loading. Please reload this page.
extracted single job execution into SingleExecutor / improved testing / do not unconditionally apply colors to output - #4882
Merged
Conversation
firewaveforce-pushed
the
single
branch
2 times, most recently
from
March 10, 2023 17:59
f05b30d to
ea912feComparefirewave
commented
Mar 10, 2023
CollaboratorAuthor
The changes in the suppression tests only occur in the tests since they are using impossible settings. This also applies to other executor-related tests will be addressed in a later PR. |
firewave
commented
Mar 10, 2023
CollaboratorAuthor
Seems like I have to fix the color stuff first. |
firewave
marked this pull request as draft
March 10, 2023 18:07
SingleExecutor / improved testingSingleExecutor / improved testing / do not unconditionally apply colors to outputfirewave
commented
Mar 10, 2023
CollaboratorAuthor
Writing the status through |
firewave
commented
Mar 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
firewave
marked this pull request as ready for review
March 10, 2023 21:43
firewaveforce-pushed
the
single
branch
2 times, most recently
from
March 12, 2023 14:33
31f5fd7 to
46ceb33Comparefirewave
commented
Mar 21, 2023
CollaboratorAuthor
Anything left to do here? |
danmar
reviewed
Mar 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
danmar
approved these changes
Apr 8, 2023
…` or `jointSuppressionReport`
…` clang-tidy warnings
… tests / adjusted tests for changed output behavior
firewave
commented
Apr 13, 2023
CollaboratorAuthor
I posted the (incomplete) follow-up as #4963. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to use shared more code between the three different executors as well as making them all behave the same in follow-up patches.