Uh oh!
There was an error while loading. Please reload this page.
removed the need for Check object in CTU::getUnsafeUsage() callback / some CheckUninitVar cleanups - #5610
Merged
Conversation
CollaboratorAuthor
This is in preparation of #5323. |
Check object in CTU::getUnsafeUsage() callbackCheck object in CTU::getUnsafeUsage() callback / some cleanupsCheck object in CTU::getUnsafeUsage() callback / some cleanupsCheck object in CTU::getUnsafeUsage() callback / some CheckUninitVar cleanupsfirewave
commented
Nov 2, 2023
| const Token* CheckUninitVar::isVariableUsage(bool cpp, const Token *vartok, const Library& library, bool pointer, Alloc alloc, int indirect) | ||
| const Token* CheckUninitVar::isVariableUsage(const Token *vartok, const Library& library, bool pointer, Alloc alloc, int indirect) | ||
| { | ||
| const bool cpp = vartok->isCpp(); |
CollaboratorAuthor
There was a problem hiding this comment.
This can simply be taken from Token as it just points back to the TokenList it belongs to. The same applies to Tokenizer::isCPP().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Checkobjects were just created for that purpose so they basically just were wrappers for the pointers passed into them and were unnecessary.