Uh oh!
There was an error while loading. Please reload this page.
reduced Tokenizer::isC() usage - #5724
Merged
Merged
Conversation
CollaboratorAuthor
I have the same changes for This should also allow us to get rid of some references being passed around - maybe even getting rid of one of the various IMO we should also be passing the |
firewave
marked this pull request as draft
December 4, 2023 23:27
firewaveforce-pushed
the
tokenizer-c
branch
3 times, most recently
from
January 9, 2024 11:59
05b773c to
2c9b09aComparefirewave
commented
Jan 15, 2024
CollaboratorAuthor
Requires #5853 to be merged first. |
firewaveforce-pushed
the
tokenizer-c
branch
2 times, most recently
from
January 20, 2024 15:25
a6c6b21 to
0412730Comparefirewave
marked this pull request as ready for review
February 27, 2024 17:59
firewave
commented
Mar 5, 2024
CollaboratorAuthor
Almost a whole week (actually three months including the draft period) without any feedback - merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
Token(should) be connected to aTokenList.Tokenizerjust encapsulates that so we have no need to check theTokenizerbut can simply ask theToken.Also if we have function calls we pass in a flag to tell it if it is C/C++ we can get rid of that flag and simply ask the
Token.