Uh oh!
There was an error while loading. Please reload this page.
testrunner: refactored givenACodeSampleToTokenize into SimpleTokenizer and SimpleTokenList / several related cleanups - #6084
Merged
Conversation
firewave
marked this pull request as draft
March 5, 2024 11:18
firewave
commented
Mar 5, 2024
CollaboratorAuthor
I didn't realize I already did this in #5299 - so adding some more changes from that. |
firewave
commented
Mar 5, 2024
CollaboratorAuthor
This will also conflict with #6049. |
givenACodeSampleToTokenize into SimpleTokenizer and SimpleTokenListgivenACodeSampleToTokenize into SimpleTokenizer and SimpleTokenList / several related cleanupsfirewave
marked this pull request as ready for review
March 5, 2024 15:04
firewave
commented
Mar 5, 2024
CollaboratorAuthor
This should be integrated into the fixture and also not use a wrapper so we can replace even more redundant code but I haven't figured that out yet. |
…izer` and `SimpleTokenList`
danmar
approved these changes
Mar 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.