Uh oh!
There was an error while loading. Please reload this page.
changed most Settings pointers to references - #6298
Merged
Merged
Conversation
firewave
commented
Apr 16, 2024
CollaboratorAuthor
Requires #6297 to be merged first. |
firewave
commented
Apr 16, 2024
CollaboratorAuthor
It is quite disconcerting that none of the tests had to be adjusted... |
firewave
commented
Apr 16, 2024
CollaboratorAuthor
I think we should wait for the next release before we apply this so we leverage the daca diffs to see if this has some kind of feedback. |
Settings pointers to referencesCollaboratorAuthor
So I went all out and changed almost all |
firewave
marked this pull request as ready for review
April 17, 2024 09:20
danmar
commented
Apr 18, 2024
Collaborator
👍 |
firewave
commented
Apr 26, 2024
CollaboratorAuthor
Would be good to merge this still early in the dev cycle so the fallout might be easier to differentiate from other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.