Skip to content

fixed #13133 - removed deprecated Qt5 support - #6678

Merged
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:qt5-remove
Aug 4, 2025
Merged

fixed #13133 - removed deprecated Qt5 support#6678
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:qt5-remove

Conversation

@firewave

@firewavefirewave commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave

firewave commented Aug 10, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Requires https://trac.cppcheck.net/ticket/12066 to be addressed first so we can put a version on the removal.

Parts of this will be extracted and put into separate PRs.

I also needed a base without the Qt5 code in to look into include-what-you-use issues/improvements for Qt.

@firewave

firewave commented Aug 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

firewave
firewave commented Aug 10, 2024
View reviewed changes
Comment threadreadme.txt Outdated

@firewavefirewaveAug 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not kept in sync with the Markdown version and I think we should remove it.

firewave
firewave commented Aug 10, 2024
View reviewed changes
Comment threadreadmeja.md

@firewavefirewaveAug 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not kept in sync with the english version and I think we should remove it. See also https://trac.cppcheck.net/ticket/11979.

@firewave

firewave commented Aug 30, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I think we can at least drop qmake support as CMake also supports Qt5.

@firewave
firewaveforce-pushed the qt5-remove branch 2 times, most recently from c6718aa to 79e4438CompareAugust 30, 2024 19:03
@firewave
firewaveforce-pushed the qt5-remove branch 3 times, most recently from 701d87a to c23b5a8CompareOctober 10, 2024 10:13
@firewave
firewaveforce-pushed the qt5-remove branch 2 times, most recently from b63737d to de7c526CompareOctober 28, 2024 10:15
@firewavefirewave changed the title removed qmake and Qt5 supportfixed #13133 - removed Qt5 supportOct 28, 2024
@firewave
firewaveforce-pushed the qt5-remove branch 4 times, most recently from 284fa0a to 3db0642CompareOctober 28, 2024 10:21
@firewave

firewave commented Oct 28, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

That goes EOS in April 2025. So I would consider that acceptable.

@firewavefirewave changed the title fixed #13133 - removed Qt5 supportfixed #13133 - removed deprecated Qt5 supportOct 28, 2024
@firewave
firewaveforce-pushed the qt5-remove branch 3 times, most recently from bc93fa2 to 113de4dCompareOctober 28, 2024 21:36
@firewavefirewave mentioned this pull request Nov 25, 2024
Draft
@firewavefirewave mentioned this pull request Feb 25, 2025
Merged
@firewavefirewave mentioned this pull request Apr 8, 2025
Merged
@firewave

firewave commented Apr 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

That goes EOS in April 2025. So I would consider that acceptable.

And it is also gone from GitHub runners soon so that issue resolved itself.

@firewave

firewave commented Aug 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

2.18.0 has been released so it is time to merged this.

Successful conditional builds with changes applied:
https://github.com/danmar/cppcheck/actions/runs/16721006441
https://github.com/danmar/cppcheck/actions/runs/16721006425

@firewave
firewave marked this pull request as ready for review August 4, 2025 11:54
@sonarqubecloud

sonarqubecloudBot commented Aug 4, 2025

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

danmar
danmar approved these changes Aug 4, 2025
View reviewed changes

@danmardanmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave
firewave merged commit 2e9b67c into cppcheck-opensource:mainAug 4, 2025
83 of 84 checks passed
@firewave
firewave deleted the qt5-remove branch August 4, 2025 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmardanmardanmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave@danmar