Uh oh!
There was an error while loading. Please reload this page.
ValueFlow: extracted valueFlowSymbolicOperators() into separate file - #6845
Merged
Conversation
firewave
commented
Sep 29, 2024
| return scope; | ||
| } | ||
| Value inferCondition(const std::string& op, const Token* varTok, MathLib::bigint val) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
firewaveforce-pushed
the
vf-symbolicop
branch
from
September 30, 2024 08:13
dc8ee28 to
ad1c990Comparefirewaveforce-pushed
the
vf-symbolicop
branch
from
September 30, 2024 12:11
ad1c990 to
2c58068Comparepfultz2
reviewed
Sep 30, 2024
| } | ||
| namespace { | ||
| struct IntegralInferModel : InferModel { |
Collaborator
There was a problem hiding this comment.
Maybe the SymbolicInferModel should be moved here as well.
CollaboratorAuthor
There was a problem hiding this comment.
Makes sense. Will do in a follow-up.
CollaboratorAuthor
There was a problem hiding this comment.
It makes sense to put them all in one place. But keeping them in the only place that uses them might also make sense. The compiler would also be able to see all the code...not 100% on what to do here.
There is also IteratorInferModel and related classes in vf_infercondition.cpp.
firewave
commented
Oct 15, 2024
CollaboratorAuthor
No further comments for two weeks - merging. |
ludviggunne pushed a commit
to ludviggunne/cppcheck
that referenced
this pull request
Oct 19, 2024
pfultz2 added a commit
to pfultz2/cppcheck
that referenced
this pull request
Nov 5, 2024
…rate file (cppcheck-opensource#6845)" This reverts commit 66d53a2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.