Uh oh!
There was an error while loading. Please reload this page.
fixed #13485 - symbol names in error messages were not serialized - #7142
Merged
Conversation
firewave
commented
Dec 27, 2024
| assert not os.path.exists(str(test_file) + '.dump') | ||
| @pytest.mark.xfail(strict=True) |
CollaboratorAuthor
There was a problem hiding this comment.
xfail because it not fully fixed until #7141 is merged.
firewave
commented
Jan 1, 2025
CollaboratorAuthor
I botched the Python test in this but since it will be failing anyways it should not matter that much (it still helped with testing this specific issue). It is also already resolved in the follow-up #7141 which builds on top of this. |
danmar
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.