Skip to content

testrunner: start adding IDs and columns to error messages - #7343

Merged
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:unique-id
Apr 7, 2025
Merged

testrunner: start adding IDs and columns to error messages#7343
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:unique-id

Conversation

@firewave

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave

firewave commented Feb 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Requires #4377 and #7342 to be merged first.

This will help with identifying missing test coverage. Those should be collected below https://trac.cppcheck.net/ticket/12232.

It will also make clearer what is being tested. And would allow to re-group/limit of of the tests (in case someone really got absolutely nothing else to do).

@firewave

This comment was marked as outdated.

@firewavefirewave changed the title testrunner: start adding IDs to error messagestestrunner: start adding IDs and columns to error messagesFeb 28, 2025
@firewave
firewaveforce-pushed the unique-id branch 3 times, most recently from d314bac to cc587b1CompareFebruary 28, 2025 18:09
@firewave
firewaveforce-pushed the unique-id branch 2 times, most recently from 89cf50d to 2bceaa8CompareMarch 19, 2025 14:10
" { }\n"
"}");
ASSERT_EQUALS("[test.cpp:1]: (style) The function 'f1' is never used.\n", errout_str());
ASSERT_EQUALS("[test.cpp:1:0]: (style) The function 'f1' is never used. [unusedFunction]\n", errout_str());

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably have a proper column.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firewave
firewaveforce-pushed the unique-id branch 4 times, most recently from f8cc900 to 1308a55CompareApril 3, 2025 08:18
@firewave
firewave marked this pull request as ready for review April 3, 2025 08:18
Comment threadtest/fixture.h
@firewave
firewave merged commit bf80216 into cppcheck-opensource:mainApr 7, 2025
@firewave
firewave deleted the unique-id branch April 7, 2025 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave@danmar